fix(enterprise): guard against null domains and trim whitespace in HRD screen - #2841
Open
ankita10119 wants to merge 2 commits into
Open
fix(enterprise): guard against null domains and trim whitespace in HRD screen#2841ankita10119 wants to merge 2 commits into
ankita10119 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
connection/enterprise.jsmatchConnection: added null guard on x.get('domains') before calling.contains()- prevents a crash when a connection has no domains configuredfindADConnectionWithoutDomain: same null guard before calling.isEmpty()connection/enterprise/hrd_screen.jsxdomain !== nulltodomain&&domain.trim()- empty or whitespace-only domain strings now fall back to the generic login instructions instead of interpolating a blank value into the enterprise instructions stringReferences
Testing
New test file
matchConnection.test.jscovers:hrd_screen.test.jsadds two new cases:All 407 tests pass.
Checklist