Skip to content

fix: emit authorization_error for too_many_attempts, guard Cordova plugin instantiation, fix SelectInput name prop - #2842

Open
ankita10119 wants to merge 1 commit into
v13from
SDK-10306-3
Open

fix: emit authorization_error for too_many_attempts, guard Cordova plugin instantiation, fix SelectInput name prop#2842
ankita10119 wants to merge 1 commit into
v13from
SDK-10306-3

Conversation

@ankita10119

Copy link
Copy Markdown
Contributor

Changes

core/actions.js

  • Added too_many_attempts to errorCodesThatEmitAuthorizationErrorEvent - the authorization_error event is now emitted when a user's account is blocked after consecutive failed logins, consistent with other blocking error codes

core/web_api/p2_api.js

  • Wrapped new CordovaAuth0Plugin() in a typeof CordovaAuth0Plugin === 'function' guard - prevents a runtime crash in non-Cordova environments where the module may not export a valid constructor

ui/input/select_input.jsx

  • Fixed InputWrap receiving the hardcoded string "location" as its name prop, now correctly passes the dynamic name prop, fixing broken CSS scoping, aria attributes, and id generation for any select input that isn't a location picker

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

All 401 existing tests pass. The too_many_attempts event change and the SelectInput fix are best verified with a running Lock instance. The Cordova guard can be confirmed by initialising Lock in a non-Cordova browser environment and verifying no constructor error is thrown.

Checklist

@ankita10119
ankita10119 requested a review from a team as a code owner July 21, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant