fix: emit authorization_error for too_many_attempts, guard Cordova plugin instantiation, fix SelectInput name prop - #2842
Open
ankita10119 wants to merge 1 commit into
Open
fix: emit authorization_error for too_many_attempts, guard Cordova plugin instantiation, fix SelectInput name prop#2842ankita10119 wants to merge 1 commit into
ankita10119 wants to merge 1 commit into
Conversation
…ugin, fix select input name prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
core/actions.jstoo_many_attemptstoerrorCodesThatEmitAuthorizationErrorEvent- theauthorization_errorevent is now emitted when a user's account is blocked after consecutive failed logins, consistent with other blocking error codescore/web_api/p2_api.jsCordovaAuth0Plugin()in a typeofCordovaAuth0Plugin === 'function'guard - prevents a runtime crash in non-Cordova environments where the module may not export a valid constructorui/input/select_input.jsxReferences
Testing
All 401 existing tests pass. The
too_many_attemptsevent change and the SelectInput fix are best verified with a running Lock instance. The Cordova guard can be confirmed by initialising Lock in a non-Cordova browser environment and verifying no constructor error is thrown.Checklist