fix(status): show harnesses in agentcore status output#1396
Conversation
computeResourceStatuses was missing harness diffing, so deployed harnesses never appeared in status output. Add harness support gated behind __PREVIEW__ compile-time flag. Constraint: harness features must be gated behind isPreviewEnabled() Rejected: Always show harnesses | GA builds must not expose harness concepts Confidence: high Scope-risk: narrow
Package TarballHow to installgh release download pr-1396-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Nice incremental change — the diffing logic is clean and the preview gating is consistent with how other preview features are wired.
The main thing I'd like to see addressed before merging is the test coverage gap around the __PREVIEW__ gate (see inline comment on the test file). The test plan has "Verify GA build does not show harness resources" as a manual step, but that could be an automated test cheaply, and would prevent accidental regressions of the gating.
A couple of small inline notes alongside that — feel free to take or leave.
Coverage Report
|
…namic --type description
|
Claude Security Review: no high-confidence findings. (run) |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Summary
agentcore statusnow displays harness resources (deployed, local-only, pending-removal) in preview buildscomputeResourceStatuses, gated behind__PREVIEW__flagharnessanddatasetto telemetry FilterType enumTest plan
agentcore statusshows harnesses after deploying a harness in preview build