Skip to content

fix(status): show harnesses in agentcore status output#1396

Merged
jesseturner21 merged 2 commits into
mainfrom
fix/status-show-harnesses
May 28, 2026
Merged

fix(status): show harnesses in agentcore status output#1396
jesseturner21 merged 2 commits into
mainfrom
fix/status-show-harnesses

Conversation

@jesseturner21
Copy link
Copy Markdown
Contributor

Summary

  • agentcore status now displays harness resources (deployed, local-only, pending-removal) in preview builds
  • Adds harness diffing to computeResourceStatuses, gated behind __PREVIEW__ flag
  • Adds harness icon to ResourceGraph TUI component
  • Adds harness and dataset to telemetry FilterType enum

Test plan

  • Unit tests pass (3 new harness tests + all 37 existing tests green)
  • Verify agentcore status shows harnesses after deploying a harness in preview build
  • Verify GA build does not show harness resources

computeResourceStatuses was missing harness diffing, so deployed
harnesses never appeared in status output. Add harness support
gated behind __PREVIEW__ compile-time flag.

Constraint: harness features must be gated behind isPreviewEnabled()
Rejected: Always show harnesses | GA builds must not expose harness concepts
Confidence: high
Scope-risk: narrow
@jesseturner21 jesseturner21 requested a review from a team May 27, 2026 19:16
@github-actions github-actions Bot added the size/s PR size: S label May 27, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 27, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.15.0.tgz

How to install

gh release download pr-1396-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz

@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 27, 2026
Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice incremental change — the diffing logic is clean and the preview gating is consistent with how other preview features are wired.

The main thing I'd like to see addressed before merging is the test coverage gap around the __PREVIEW__ gate (see inline comment on the test file). The test plan has "Verify GA build does not show harness resources" as a manual step, but that could be an automated test cheaply, and would prevent accidental regressions of the gating.

A couple of small inline notes alongside that — feel free to take or leave.

Comment thread src/cli/commands/status/__tests__/action.test.ts
Comment thread src/cli/commands/status/command.tsx
Comment thread src/cli/commands/status/command.tsx Outdated
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 35.01% 10667 / 30463
🔵 Statements 34.36% 11329 / 32971
🔵 Functions 29.95% 1808 / 6036
🔵 Branches 29.01% 6737 / 23220
Generated in workflow #3331 for commit 8702812 by the Vitest Coverage Report Action

@github-actions github-actions Bot removed the size/s PR size: S label May 27, 2026
@github-actions github-actions Bot added the size/m PR size: M label May 27, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 27, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 27, 2026
@tejaskash
Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@jesseturner21 jesseturner21 merged commit 7afb3da into main May 28, 2026
32 checks passed
@jesseturner21 jesseturner21 deleted the fix/status-show-harnesses branch May 28, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants