[v2] Avoid PSModulePath inheritance during update on Windows - #10541
Open
hssyoo wants to merge 1 commit into
Open
[v2] Avoid PSModulePath inheritance during update on Windows#10541hssyoo wants to merge 1 commit into
hssyoo wants to merge 1 commit into
Conversation
1 task
aemous
added
accessanalyzer
v2
update
customization
aemous
self-requested a review
August 10, 2026 17:53
aemous
approved these changes
Aug 10, 2026
aemous
left a comment
aemous
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Confirmed via internal discussions that this was manually tested on a Windows machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10532
Currently,
updatelaunches a PS5 console viapowershell.exewhen running the install script. This causes an issue where if theupdatecommand is run within a PS7 console, the PS5 execution inherits PS7'sPSModulePathenv var value, leading to path issues when the install script attempts to runGet-AuthenticodeSignature.This PR fixes the issue by removing
PSModulePathbefore launching PS5, letting it rebuild its defaultPSModulePathvalue. The PR also falls back topwsh.exe(PS7) ifpowershell.exeisn't available when resolving the PowerShell path.