fix(otel): Fix X-Ray trace integration and cross-invocation retry spans#508
Open
ayushiahjolia wants to merge 1 commit into
Open
fix(otel): Fix X-Ray trace integration and cross-invocation retry spans#508ayushiahjolia wants to merge 1 commit into
ayushiahjolia wants to merge 1 commit into
Conversation
ayushiahjolia
force-pushed
the
fix/otel-plugin-xray-integration
branch
2 times, most recently
from
ec15f90 to
9a7cb23
Compare
ayushiahjolia
force-pushed
the
fix/otel-plugin-xray-integration
branch
from
9a7cb23 to
5c269c3
Compare
SilanHe
reviewed
Jun 30, 2026
| - AdotArch: amd64 | ||
| Environment: | ||
| Variables: | ||
| AWS_LAMBDA_EXEC_WRAPPER: /opt/otel-handler |
Contributor
There was a problem hiding this comment.
how come we don't need this anymore?
| Instant startTimestamp, | ||
| Instant endTimestamp) {} | ||
| Instant endTimestamp, | ||
| boolean isContinuation) {} |
Contributor
There was a problem hiding this comment.
nit: we're using isReplay in JS (I think it can still be confusing but replay is a terminology that is more commonly used around durable functions). I can be convinced otherwise
Contributor
There was a problem hiding this comment.
how is this new variable currently being used? I'm not seeing changes in the sdk itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#507
Description
Fixes OTel plugin X-Ray integration: cross-invocation retry span grouping, trace context extraction, and trace map display to match the JS SDK behavior.
System.getenv("_X_AMZN_TRACE_ID")returned stale/null values due to JVM env caching, so the plugin fell back to an ARN-derived trace ID disconnected from Lambda's X-Ray segments.service.nameresource andSpanKind.SERVERprevented X-Ray from creating a distinct service node for durable execution spans.Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? Yes
Integration Tests
Have integration tests been written for these changes? N/A
Examples
Has a new example been added for the change? (if applicable) Updated existing ones.