chore(lint): Enable Pyflakes rules across all packages#497
Open
ayushiahjolia wants to merge 1 commit into
Open
chore(lint): Enable Pyflakes rules across all packages#497ayushiahjolia wants to merge 1 commit into
ayushiahjolia wants to merge 1 commit into
Conversation
8dda1c3 to
976823e
Compare
976823e to
8a0fcc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #479
Description of changes:
Enables the Pyflakes (
F) rule category in ruff across all packages. reviously onlyTID252(ban relative imports) was enforced, meaning unused imports, undefined names, and unused variables went undetected.Testing -
ci-checks.shpasses (tests, coverage, typecheck, fmt for all packages)ruff check --select F,TID252reports zero violationsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.