test: unskip nova tests#5901
Merged
Merged
Conversation
aviruthen
reviewed
May 29, 2026
Collaborator
There was a problem hiding this comment.
Are we running these tests in a different account? E.g. 784379639078 instead of 729646638167?
aviruthen
approved these changes
May 29, 2026
mujtaba1747
reviewed
May 29, 2026
| """Test creating RLVR dataset from S3 URI.""" | ||
| """Test creating Nova DPO dataset from S3 URI.""" | ||
| s3_uri = f"s3://{test_bucket}/test_datasets/Nova/nova_dpo_train.jsonl" | ||
| dataset = DataSet.create( |
Collaborator
There was a problem hiding this comment.
There's no cleanup for DataSet.create()?
Collaborator
Author
There was a problem hiding this comment.
There is cleanup — the cleanup_list fixture handles it. Each test appends the created dataset to cleanup_list, and the fixture's teardown calls resource.delete() on all tracked resources (see conftest.py line ~108-113).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Nova model integration tests to run in the dedicated us-east-1 test account (784379639078). This PR migrates the Nova tests from being skipped to being selectable via a new
us_east_1pytest marker, allowing them to run in the new account's CI infrastructure set up in #5900.Changes
us_east_1pytest marker (tox.ini): Registered a new marker to identify tests that require us-east-1 account credentials.@pytest.mark.skipwith@pytest.mark.us_east_1on all Nova-related integration tests.max_wait_timeto 3 hours for SFT/RLVR trainer tests and benchmark evaluator test, as Nova training jobs take >1 hour to complete.Tests affected
test_sft_trainer_nova_workflowtest_sft_trainer_integration.pygpu_intensive,us_east_1test_rlvr_trainer_nova_workflowtest_rlvr_trainer_integration.pygpu_intensive,us_east_1test_benchmark_evaluation_nova_modeltest_benchmark_evaluator.pygpu_intensive,us_east_1test_create_dataset_from_s3_nova_*(4 tests)test_dataset.pyserial,us_east_1How it works
-m "us_east_1 and not serial"and-m "us_east_1 and serial"via theinteg-tests-us-east-1job added in test: add a job to invoke code build project in us-east-1 #5900.gpu_intensivemarked tests (SFT, RLVR, benchmark) will run in the scheduledgpu-integ-tests-us-east-1job.-m "not us_east_1"to exclude these tests.Testing
All 7 tests validated via PR check runs