fix/issue 5897 crlf sm train - #6088
Open
wasim-builds wants to merge 1 commit into
Open
Conversation
wasim-builds
had a problem deploying
to
manual-approval
July 23, 2026 08:13 — with 
GitHub Actions
Error
GitHub Actions
Error
wasim-builds
had a problem deploying
to
manual-approval
July 23, 2026 08:13 — with
GitHub Actions
Error
GitHub Actions
Error
wasim-builds
had a problem deploying
to
manual-approval
July 23, 2026 08:13 — with
GitHub Actions
Error
GitHub Actions
Error
wasim-builds
had a problem deploying
to
manual-approval
July 24, 2026 05:51 — with
GitHub Actions
Error
GitHub Actions
Error
wasim-builds
had a problem deploying
to
manual-approval
July 24, 2026 05:51 — with
GitHub Actions
Error
GitHub Actions
Error
wasim-builds
had a problem deploying
to
manual-approval
July 24, 2026 05:51 — with
GitHub Actions
Error
GitHub Actions
Error
wasim-builds
force-pushed
the
fix/issue-5897-crlf-sm-train
branch
from
July 25, 2026 09:01
15e650b to
fa7b7aa
Compare
wasim-builds
requested a deployment
to
manual-approval
July 25, 2026 09:01 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
wasim-builds
requested a deployment
to
manual-approval
July 25, 2026 09:01 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
wasim-builds
requested a deployment
to
manual-approval
July 25, 2026 09:01 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5897
Problem
ModelTrainerwrites files with platform-default line endings, causing CRLF/LF inconsistencies on Windows.Fix
Explicitly normalize line endings to LF when writing training artifacts.
Scope
Single-line change in
sagemaker-train/src/sagemaker/train/model_trainer.py.Verification
Training artifacts now have consistent LF line endings regardless of OS.