Skip to content

Disable path mapping when rustc_env has location expansions#4117

Open
airtrick-rgb wants to merge 1 commit into
bazelbuild:mainfrom
airtrick-rgb:path-map-rustc-env
Open

Disable path mapping when rustc_env has location expansions#4117
airtrick-rgb wants to merge 1 commit into
bazelbuild:mainfrom
airtrick-rgb:path-map-rustc-env

Conversation

@airtrick-rgb

Copy link
Copy Markdown

Location expansion happens outside the control of path mapping logic and would produce paths with build configuration in them, breaking path mapping's logic of replacing all build configuration with the literal "cfg".

@UebelAndre UebelAndre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@UebelAndre UebelAndre added this pull request to the merge queue Jun 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@UebelAndre

Copy link
Copy Markdown
Collaborator

I added some regression testing for this in #4120

@UebelAndre UebelAndre added this pull request to the merge queue Jun 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@UebelAndre UebelAndre added this pull request to the merge queue Jun 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@UebelAndre UebelAndre added this pull request to the merge queue Jul 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants