Skip to content

fix token persistence#1778

Merged
luke-lombardi merged 1 commit into
mainfrom
ll/fix-token-persistence
Jul 17, 2026
Merged

fix token persistence#1778
luke-lombardi merged 1 commit into
mainfrom
ll/fix-token-persistence

Conversation

@luke-lombardi

@luke-lombardi luke-lombardi commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Make private pool join tokens persistent and machine-scoped to handle long provider boot times. Revoke tokens on reservation close or rollback, and keep legacy tokens (without PoolCreatedAt) working.

  • Bug Fixes

    • Use non-expiring, machine-scoped tokens in launchPoolCapacityLocked; replaces TTL-based token path.
    • Revoke reservation tokens in terminateReservation and during launch rollback.
    • Accept legacy tokens with zero PoolCreatedAt; compare timestamps only when both exist.
    • Clarify error: "join token was issued for a previous instance of this pool."
    • Add tests for legacy token acceptance and the new error.
  • Refactors

    • Add createPersistentPrivatePoolJoinCommandForWorkspace() and joinCommandForToken().
    • Update call sites to use the persistent join command.

Written for commit 4b0dca5. Summary will update on new commits.

Review in cubic

@luke-lombardi
luke-lombardi merged commit d85e29b into main Jul 17, 2026
3 checks passed
@luke-lombardi
luke-lombardi deleted the ll/fix-token-persistence branch July 17, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant