Fix pod proxy shutdown retirement race#1780
Merged
Merged
Conversation
luke-lombardi
marked this pull request as ready for review
July 18, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The autoscaler could select an idle pod for shutdown while its route and HTTP keepalive transport were still published. A request arriving at the shutdown boundary could reuse that transport and receive an immediate 502 instead of waiting for a checkpoint restore. Discovery could also republish the still-RUNNING container before Scheduler.Stop committed STOPPING.
Validation
Summary by cubic
Fixes a shutdown race in the pod proxy that caused 502s at scale-down. The proxy now retires backends before stopping containers, propagates STOPPING across replicas, and queues cold-starts when another gateway holds the scaling lock.
Scheduler.Stopto prevent keepalive reuse.PodProxyBufferand filter them during discovery; allow canceling retirement if needed.Written for commit 8cbac86. Summary will update on new commits.