Skip to content

Add Naeem Saleem notice board feature - #83

Open
naeemsaleem2003 wants to merge 1 commit into
becloudready:masterfrom
naeemsaleem2003:NaeemSaleem_Feature
Open

Add Naeem Saleem notice board feature#83
naeemsaleem2003 wants to merge 1 commit into
becloudready:masterfrom
naeemsaleem2003:NaeemSaleem_Feature

Conversation

@naeemsaleem2003

Copy link
Copy Markdown

What changed

  • added an isolated submission under bank-applicationMC/NaeemSaleem
  • adapted the bank-project frontend branding into a responsive Notice Board
  • added posting, newest-first display, deletion, validation, and browser persistence
  • added local setup and validation instructions

Why

This completes the Notice Board feature assignment while keeping all student work isolated in the required personal subfolder.

Validation

  • npm run build
  • npm audit: 0 vulnerabilities

@NateLevi NateLevi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your frontend changes look good, approved!

@M1tchellC M1tchellC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes and everything looks good to me, so I am approving. I liked the approach of modifying App.jsx to handle the functionality as opposed to the login screen. It keeps the flow centralized and makes the implementation easy to follow. Nice work Naeem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants