erlang: support OTP 29 and HTTP/3 server verification#855
Closed
benoitc wants to merge 3 commits into
Closed
Conversation
Replace the deprecated catch expression with try across the codebase so hackney compiles cleanly on OTP 29, reusing small stop/close helpers instead of repeating the wrapper. Wire hackney's TLS options through to the QUIC connection so HTTP/3 honors the request's insecure option and uses certifi as the default trust store, matching the HTTPS path, now that quic 1.4.4 verifies the server certificate by default. Add OTP 29 to the CI matrix.
0.6.1 replaces the deprecated catch form, so the dependency builds on OTP 29 without warnings_as_errors failing.
Drop the now-unreachable catch-all in getbyname (try cannot yield the
{'EXIT', _} the old catch did) and have the trace safe/1 helper return
ok so its result is not an unmatched union.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #854 (quic 1.4.4 bump).
quic 1.4.4 verifies the server certificate by default. hackney now passes its TLS options through to the QUIC connection so HTTP/3 honors the request's
insecureoption and CA configuration, defaulting to the certifi trust store like the HTTPS path.Also replaces the deprecated
catch Exprform withtry ... catchso hackney compiles cleanly on OTP 29, bumps h2 to 0.6.1 (which carries the same fix), and adds OTP 29 to the CI matrix.