Skip to content

Fix relocation stub: add parent so it can actually be signed+published#145

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/llm-wiki-architecture-plan-0nvriu
Jul 15, 2026
Merged

Fix relocation stub: add parent so it can actually be signed+published#145
bernardladenthin merged 1 commit into
mainfrom
claude/llm-wiki-architecture-plan-0nvriu

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

  • The llamacpp-ai-index-maven-plugin relocation-stub module (from the previously-merged srcmorph: extract core+CLI, rename plugin, bump to 1.1.0, fix reactor CI #144) had no <parent>, so it inherited neither the release profile's maven-gpg-plugin signing execution nor its central-publishing-maven-plugin binding. Running the real mvn -P release deploy would have hit this module with nothing configured to sign or publish it — no <distributionManagement><repository> either — falling through to the plain Super-POM maven-deploy-plugin:deploy binding for pom packaging, which needs an explicit deployment repository this file correctly doesn't declare. That would fail the whole reactor deploy the moment it reached this module (or at best leave the relocation POM never actually published, defeating its purpose).
  • Fix: add <parent>srcmorph-parent</parent> while keeping this module's own explicit <version>1.0.4</version> as a deliberate override — Maven fully supports a child pinning a different version than its parent; only omitting <version> inherits the parent's.

Test plan

  • Effective POM under -P release now shows both maven-gpg-plugin and central-publishing-maven-plugin bound for this module (previously absent even with -P release explicitly passed)
  • Effective POM's own <version> still resolves to 1.0.4 (not clobbered to the parent's 1.1.0)
  • <distributionManagement><relocation> unchanged — still points at net.ladenthin:srcmorph-maven-plugin:1.1.0
  • Re-tested mvn versions:set -DnewVersion=X -Dexcludes=net.ladenthin:llamacpp-ai-index-maven-plugin in a scratch copy — the stub's version correctly stays pinned while the rest of the reactor bumps, confirming the existing exclusion guidance still works with the new <parent> in place
  • mvn clean verify from repo root — BUILD SUCCESS
  • CI green on this branch (pending)

Related issues / PRs

Follow-up to #144 (merged) — this closes a gap discovered while double-checking release-readiness after that merge.

Checklist

  • I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • My commits follow Conventional Commits
  • No security-sensitive changes

Generated by Claude Code

The stub had no <parent>, so it inherited neither the release profile's
maven-gpg-plugin signing execution nor its central-publishing-maven-plugin
binding. Running the real `mvn -P release deploy` would have hit this
module with nothing configured to sign or publish it (no
<distributionManagement><repository> either), falling through to the
plain Super-POM maven-deploy-plugin:deploy binding for pom packaging,
which needs an explicit deployment repository this file correctly
doesn't declare - failing the whole reactor deploy.

Add <parent> (srcmorph-parent) while keeping this module's own explicit
<version>1.0.4</version> as a deliberate override - Maven fully supports
a child pinning a different version than its parent. Verified: effective
POM under -P release now shows both maven-gpg-plugin and
central-publishing-maven-plugin, the stub's own version stays 1.0.4 (not
clobbered to 1.1.0), the existing `versions:set -Dexcludes=...` guidance
still protects it correctly (re-tested in a scratch copy), and a full
`mvn clean verify` from root still passes.
@bernardladenthin
bernardladenthin merged commit faf51cc into main Jul 15, 2026
8 of 14 checks passed
@bernardladenthin
bernardladenthin deleted the claude/llm-wiki-architecture-plan-0nvriu branch July 15, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants