Alternative InvertibleComponentIdSet#24809
Open
chescock wants to merge 1 commit into
Open
Conversation
chescock
added
A-ECS
Zeophlite
reviewed
Jun 29, 2026
|
|
||
| /// If this is a finite set, returns the set. | ||
| /// If this is an unbounded set, returns `None`. | ||
| pub fn as_finite_set(&self) -> Option<&ComponentIdSet> { |
Contributor
There was a problem hiding this comment.
Could you add as_exclusion_set() that returns None for Included, and the set for Excluded
Zeophlite
reviewed
Jun 29, 2026
| /// Removes all [`ComponentId`]s from the set. | ||
| #[inline] | ||
| pub fn clear(&mut self) { | ||
| *self = Self::new(); |
Contributor
There was a problem hiding this comment.
Is re alloc'ing okay for perf?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Allow
Accessto be inspected forEntityMutExcept<B>queries.Simplify the code that handles inverted access, particularly the
forloops inis_compatible,is_subset, andget_conflicts.Solution
Create an
enum InvertibleComponentIdSetwith separate variants for finite and unbounded sets, and use it inAccess.Alternative to #24771 and #24789