Skip to content

Robustly bump dependency versions#79

Merged
wilsonyhlee merged 1 commit into
mainfrom
chore-update-versions
Apr 28, 2022
Merged

Robustly bump dependency versions#79
wilsonyhlee merged 1 commit into
mainfrom
chore-update-versions

Conversation

@jaketae

@jaketae jaketae commented Apr 28, 2022

Copy link
Copy Markdown
Member

In light of #74, this PR flexibly bumps project dependency versions by replacing hardcoded == version requirements with >=. This will allow pip to install the latest versions when possible and also resolve the test CI error.

Additionally,

  • The unnecessary tensorflow dependency is removed
  • Dependencies are re-ordered to give priority to torch and transformers

@jaketae jaketae requested a review from wilsonyhlee April 28, 2022 05:35
@jaketae

jaketae commented Apr 28, 2022

Copy link
Copy Markdown
Member Author

@tianjianjiang, can you help update poetry.lock and pyproject.toml files? I think the test CI currently works off of setup.py, which reads from requirements.txt, but I think it's also a good idea to keep other files consistent if we update requirements.txt. Thank you!

@jaketae jaketae requested a review from tttyuntian April 28, 2022 05:37

@wilsonyhlee wilsonyhlee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wilsonyhlee wilsonyhlee merged commit 9526562 into main Apr 28, 2022
@wilsonyhlee wilsonyhlee deleted the chore-update-versions branch April 28, 2022 05:39
@tianjianjiang

Copy link
Copy Markdown
Contributor

@tianjianjiang, can you help update poetry.lock and pyproject.toml files? I think the test CI currently works off of setup.py, which reads from requirements.txt, but I think it's also a good idea to keep other files consistent if we update requirements.txt. Thank you!

@jaketae Roger that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants