[attachments] inline images support - #45
Open
capcom6 wants to merge 5 commits into
Open
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe frontend adds inline image uploads for task descriptions and comments. Uploaded images become attachment Markdown. Task and comment rendering resolves attachment references to download URLs before Markdown parsing. Prose images receive constrained, rounded styling. ChangesInline image attachments
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Author
participant CommentForm
participant uploadInlineImage
participant AttachmentUploadAPI
participant TaskDetail
participant CommentList
Author->>CommentForm: Select, paste, or drop an image
CommentForm->>uploadInlineImage: Upload image for task
uploadInlineImage->>AttachmentUploadAPI: Initialize, transfer, and confirm upload
AttachmentUploadAPI-->>uploadInlineImage: Return attachment metadata
uploadInlineImage-->>CommentForm: Return upload result
CommentForm->>TaskDetail: Submit comment with attachment reference
TaskDetail->>TaskDetail: Refetch task and attachment URLs
TaskDetail->>CommentList: Pass attachment URL map
CommentList->>CommentList: Resolve attachment reference before Markdown parsing
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (2)
frontend/src/lib/components/TaskForm.svelte (1)
106-111: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove the unused
extbinding and the no-oponProgresscallback.♻️ Cleanup
- const result = await uploadInlineImage(taskId, file, { - onProgress: (_pct) => {}, - }); - const ext = result.fileName.replace(/^.*\./, ""); + const result = await uploadInlineImage(taskId, file); const name = result.fileName.replace(/\.[^.]+$/, "");🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/src/lib/components/TaskForm.svelte` around lines 106 - 111, In the TaskForm upload flow, remove the unused ext binding derived from result.fileName and omit the no-op onProgress callback when calling uploadInlineImage; preserve the existing filename handling and insertAtCursor behavior.frontend/src/lib/components/CommentForm.svelte (1)
21-93: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winThis block is a near-verbatim copy of
TaskForm.sveltelines 85-159.Cursor insertion, upload gating, pick/paste/drop/dragover handlers, and the button+hidden-input markup are duplicated. Extracting a shared helper (e.g.
createInlineImageUploader(taskId, getText, setText, getEl)) plus a smallInlineImageButton.sveltewould keep the two forms from diverging.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/src/lib/components/CommentForm.svelte` around lines 21 - 93, The inline-image functionality in CommentForm, including insertAtCursor, upload gating, pick/paste/drop/dragover handlers, and related button/input markup, duplicates TaskForm. Extract the shared behavior into a reusable inline-image uploader helper and the shared controls into an InlineImageButton component, then update both forms to use them while preserving their existing task ID, text, textarea, upload, and toast behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/lib/components/TaskForm.svelte`:
- Around line 141-154: Update handleImageDrop in
frontend/src/lib/components/TaskForm.svelte (lines 141-154) and the
corresponding drop handler in frontend/src/lib/components/CommentForm.svelte
(lines 75-88) to be async and await uploadAndInsert(file) for each image,
preserving sequential processing and existing non-image toast behavior.
In `@frontend/src/lib/resolve-attachment-refs.ts`:
- Around line 17-22: Update the attachment URL replacement in
resolveAttachmentRefs so it no longer appends accessToken or any bearer JWT as a
query parameter. Use the existing same-origin cookie authentication,
authenticated fetch/blob flow, or a short-lived attachment-scoped token
mechanism while preserving the current task and attachment path generation.
In `@frontend/src/lib/upload-image.ts`:
- Around line 36-50: Update the XMLHttpRequest timeout in the upload flow around
the xhr.timeout assignment so supported image uploads, including 100 MiB files
below roughly 14 Mbps, are not aborted after 60 seconds. Use a size-aware or
multi-minute timeout based on the upload size, while ensuring it remains bounded
by the presigned URL’s expiry.
In `@internal/server/middlewares/jwtauth/jwtauth.go`:
- Around line 30-33: The image-route bypass in jwtauth.Next must apply only when
the request has no Authorization header; update the predicate so
header-authenticated requests reach jwtauth.GetUser. In
internal/server/middlewares/jwtauth/jwtauth.go lines 30-33, make this
conditional change. In internal/server/tasks/handler_attachments.go lines
119-139, preserve the query-token branch as the fallback for requests without
middleware-provided authentication; consider issuing a short-lived
attachment-scoped token instead of embedding the access token in URLs.
In `@internal/server/tasks/handler_attachments.go`:
- Around line 164-169: Update the attachment download flow around
PresignedGetObject so validated image extensions determine the headers on the
actual MinIO GET response, not only the redirect. Either stream the validated
image through the handler or pass response content-type and disposition
overrides when generating the presigned URL, and set X-Content-Type-Options to
nosniff while preserving the allowed MIME type.
---
Nitpick comments:
In `@frontend/src/lib/components/CommentForm.svelte`:
- Around line 21-93: The inline-image functionality in CommentForm, including
insertAtCursor, upload gating, pick/paste/drop/dragover handlers, and related
button/input markup, duplicates TaskForm. Extract the shared behavior into a
reusable inline-image uploader helper and the shared controls into an
InlineImageButton component, then update both forms to use them while preserving
their existing task ID, text, textarea, upload, and toast behavior.
In `@frontend/src/lib/components/TaskForm.svelte`:
- Around line 106-111: In the TaskForm upload flow, remove the unused ext
binding derived from result.fileName and omit the no-op onProgress callback when
calling uploadInlineImage; preserve the existing filename handling and
insertAtCursor behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 41c1995d-fd76-4b2a-9d96-62adf8461d11
📒 Files selected for processing (13)
frontend/src/app.cssfrontend/src/lib/components/CommentForm.sveltefrontend/src/lib/components/CommentList.sveltefrontend/src/lib/components/TaskForm.sveltefrontend/src/lib/pages/task-detail.sveltefrontend/src/lib/pages/task-edit.sveltefrontend/src/lib/resolve-attachment-refs.tsfrontend/src/lib/upload-image.tsinternal/attachments/service.gointernal/server/middlewares/jwtauth/jwtauth.gointernal/server/tasks/handler.gointernal/server/tasks/handler_attachments.gointernal/storage/service.go
🤖 Pull request artifacts
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/lib/pages/task-detail.svelte`:
- Around line 55-57: Update uploadInlineImage so the successful upload
confirmation refreshes the local task attachment data used by the attachmentUrls
derived map. Either merge the confirmed attachment into task.attachments or
refetch the task after createComment completes, ensuring newly uploaded comment
images resolve immediately without requiring a page refresh.
In `@frontend/src/lib/resolve-attachment-refs.ts`:
- Around line 2-5: The attachment reference replacement in the resolver should
emit resolved URLs using Markdown angle-bracket destinations. Update the image
rendering in the relevant resolve-attachment function to produce
``, preserving the existing alt text and URL, and add coverage for
a presigned URL containing whitespace or a Markdown delimiter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2215660a-f4e6-4948-8fe7-8813d93c351c
📒 Files selected for processing (6)
frontend/src/lib/components/CommentForm.sveltefrontend/src/lib/components/CommentList.sveltefrontend/src/lib/components/TaskForm.sveltefrontend/src/lib/pages/task-detail.sveltefrontend/src/lib/resolve-attachment-refs.tsfrontend/src/lib/upload-image.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- frontend/src/lib/components/CommentForm.svelte
- frontend/src/lib/upload-image.ts
- frontend/src/lib/components/TaskForm.svelte
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/lib/pages/task-detail.svelte`:
- Around line 146-162: Update addAttachment and each upload caller
(AttachmentUpload, CommentForm, and uploadInlineImage) to capture the current
task ID before starting an upload, pass that captured ID with the confirmation,
and ignore confirmations when it differs from the task that initiated the
upload. Ensure addAttachment uses the captured task context rather than the
mutable taskId/task values, preventing stale confirmations from dereferencing
reset task data or mutating another task.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d8b87a3a-0e9f-49d6-9e17-bf04a4ee268f
📒 Files selected for processing (4)
frontend/src/lib/components/CommentForm.sveltefrontend/src/lib/pages/task-detail.sveltefrontend/src/lib/resolve-attachment-refs.tsfrontend/src/lib/upload-image.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- frontend/src/lib/upload-image.ts
- frontend/src/lib/components/CommentForm.svelte
- frontend/src/lib/resolve-attachment-refs.ts
capcom6
force-pushed
the
attachments/inline-images-support
branch
from
August 3, 2026 05:03
70bc9f1 to
ee45d5e
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/lib/components/CommentForm.svelte`:
- Around line 122-131: Update the Insert image button in CommentForm so its
disabled state also includes a falsy taskId, alongside uploading; preserve the
existing click behavior and upload handling for valid task IDs.
- Around line 37-50: Update uploadAndInsert to sanitize the filename-derived
name before passing it to insertAtCursor: strip or escape backslashes, [
characters, and ] characters so the generated Markdown alt text remains valid
for resolveAttachmentRefs. Keep the existing filename extension removal and
attachment insertion behavior unchanged.
In `@frontend/src/lib/upload-image.ts`:
- Around line 56-58: Update the xhr.onerror handler in the upload flow to use a
generic upload-failure error rather than asserting S3 dev-mode unavailability;
keep the existing timeout handling unchanged and only use dev-specific wording
from an explicit dev-only path if one exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 56d0535e-5d13-43e8-b05a-f979b2ab4cc5
📒 Files selected for processing (10)
frontend/src/app.cssfrontend/src/lib/components/CommentForm.sveltefrontend/src/lib/components/CommentList.sveltefrontend/src/lib/components/TaskForm.sveltefrontend/src/lib/pages/task-detail.sveltefrontend/src/lib/pages/task-edit.sveltefrontend/src/lib/resolve-attachment-refs.tsfrontend/src/lib/upload-image.tsinternal/attachments/service.gointernal/storage/service.go
🚧 Files skipped from review as they are similar to previous changes (7)
- frontend/src/lib/pages/task-edit.svelte
- frontend/src/app.css
- frontend/src/lib/resolve-attachment-refs.ts
- internal/storage/service.go
- internal/attachments/service.go
- frontend/src/lib/components/CommentList.svelte
- frontend/src/lib/components/TaskForm.svelte
capcom6
force-pushed
the
attachments/inline-images-support
branch
from
August 4, 2026 01:09
ae19cbb to
afac4d1
Compare
capcom6
marked this pull request as ready for review
August 4, 2026 07:42
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/src/lib/components/CommentForm.svelte (1)
21-41: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winBlock persistence while attachment Markdown is pending.
Both forms can persist their content before the active image upload updates the bound text.
frontend/src/lib/components/CommentForm.svelte#L21-L41: reject submission whileimages.uploadingis true.frontend/src/lib/components/CommentForm.svelte#L59-L72: disable the submit button whileimages.uploadingis true.frontend/src/lib/components/TaskForm.svelte#L84-L105: reject saving and disable the save control whileimages.uploadingis true.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/src/lib/components/CommentForm.svelte` around lines 21 - 41, Block CommentForm.handleSubmit and the corresponding submit button while images.uploading is true, and apply the same guard and disabled state to TaskForm’s save flow and control. Update frontend/src/lib/components/CommentForm.svelte lines 21-41 to reject submission, lines 59-72 to disable submission, and frontend/src/lib/components/TaskForm.svelte lines 84-105 to reject saving and disable saving until the active image upload completes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/lib/components/CommentList.svelte`:
- Around line 40-47: Update the InlineImageEditor setup in startEdit to capture
the comment’s original editingId and verify it is still active before applying
upload results through setValue; prevent the upload callback from mutating
editText when cancelEdit or switching to another comment has changed editingId.
Apply the same guard to the related edit/cancel flow referenced in the
additional ranges, preserving normal updates when the original comment remains
active.
---
Outside diff comments:
In `@frontend/src/lib/components/CommentForm.svelte`:
- Around line 21-41: Block CommentForm.handleSubmit and the corresponding submit
button while images.uploading is true, and apply the same guard and disabled
state to TaskForm’s save flow and control. Update
frontend/src/lib/components/CommentForm.svelte lines 21-41 to reject submission,
lines 59-72 to disable submission, and
frontend/src/lib/components/TaskForm.svelte lines 84-105 to reject saving and
disable saving until the active image upload completes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a0e1fbba-3ec1-4ee4-b615-26518649fb29
📒 Files selected for processing (6)
frontend/src/lib/components/CommentForm.sveltefrontend/src/lib/components/CommentList.sveltefrontend/src/lib/components/InlineImageButton.sveltefrontend/src/lib/components/TaskForm.sveltefrontend/src/lib/inline-image-editor.svelte.tsfrontend/src/lib/pages/task-detail.svelte
🚧 Files skipped from review as they are similar to previous changes (1)
- frontend/src/lib/pages/task-detail.svelte
Contributor
Author
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit