docs(rpc): add Emitter::next_block and Emitter::mempool examples#2210
Open
kwsantiago wants to merge 1 commit into
Open
docs(rpc): add Emitter::next_block and Emitter::mempool examples#2210kwsantiago wants to merge 1 commit into
kwsantiago wants to merge 1 commit into
Conversation
kwsantiago
requested review from
ValuedMammal,
evanlinjin and
oleonardolima
as code owners
kwsantiago
force-pushed
the
docs/emitter-rustdoc-examples
branch
from
d7e0362 to
3c416e2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2210 +/- ##
==========================================
- Coverage 77.69% 77.36% -0.34%
==========================================
Files 29 29
Lines 5801 5826 +25
Branches 271 273 +2
==========================================
Hits 4507 4507
- Misses 1223 1248 +25
Partials 71 71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Could you rebase again? |
kwsantiago
force-pushed
the
docs/emitter-rustdoc-examples
branch
from
3c416e2 to
78a1729
Compare
kwsantiago
changed the title
nymius
approved these changes
May 26, 2026
evanlinjin
requested changes
Jun 7, 2026
kwsantiago
force-pushed
the
docs/emitter-rustdoc-examples
branch
from
78a1729 to
0dfeb47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
# Examplerustdoc toEmitter::next_blockandEmitter::mempool, which were flagged as missing in the #2006 review.Originally this PR also removed
example_bitcoind_rpc_polling, but #2006 has since merged and removed all example crates, so that part is dropped after rebase. Only the doc additions remain.Part of the #2006 follow-up to document the components previously covered by the
examples/crates.