Rework the lighthouse geometry estimator#747
Conversation
krichardsson
changed the title
# Conflicts: # src/cfclient/ui/tabs/lighthouse_tab.py
…crazyflie disconnection
…ples used in the geometry estimation. Updated the lighthouse tab doc.
enyanil
left a comment
enyanil
left a comment
There was a problem hiding this comment.
Very nice updates, easy to follow and descriptive! I added comments with my opinions if there are changes you want to implement
There was a problem hiding this comment.
The numbering is very confusing to me. Is there a reason this is not going from left to right and top to bottom. It make the corresponding text difficult to follow.
There was a problem hiding this comment.
To me it looks like the 5 is the 3d view and not the sample collection. Perhaps try a green square with a white 5 in the top corner.
| match notification_type: | ||
| case _UserNotificationType.SUCCESS: | ||
| self._helper.cf.platform.send_user_notification(True) | ||
| self._helper.cf.param.set_value('led_deck_ctrl.rgb888', LED_DECK_RGB888_GREEN) |
There was a problem hiding this comment.
oh nice! Did we also play with spinning the propellers at some point? or flashing the bitmask?
Either way we should mention this in the blog post I think.
| _changeable = self._selected_sample_type in (LhCfPoseSampleType.XYZ_SPACE, LhCfPoseSampleType.VERIFICATION) | ||
| self._change_type_sample_button.setEnabled(_changeable) | ||
| self._change_type_sample_button.setToolTip( | ||
| '' if _changeable else 'Switching types of samples is only available for XYZ and Verification samples') |
There was a problem hiding this comment.
What other kinds of sample are there? Excluded samples?
5 participants
This PR contains changes that aims at reworking the lighthouse geometry estimator to make it easier to use and help the use to better understand the state of the system.
This is work in progress.
This PR breaks APIs and it should be used together with PR bitcraze/crazyflie-lib-python#543 in the client.