fix: send CSV imports as JSON instead of multipart/form-data#1306
Open
jeremydw wants to merge 1 commit into
Open
fix: send CSV imports as JSON instead of multipart/form-data#1306jeremydw wants to merge 1 commit into
jeremydw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CMS translations CSV import (
LocalizationModal) uploads the selected file to/cms/api/csv.importasmultipart/form-data. Some production deployments sit behind WAFs/edge proxies that blockmultipart/form-dataPOSTs outright, so the request is rejected before it ever reaches the server and the import fails with an opaque error.Change
csv.importnow accepts a JSON body ({"csv": "<csv text>"}) in addition to the existingmultipart/form-dataupload (kept for backwards compatibility).file.text()) and sends it as JSON./cms/api/csv.importis included in the routes that use the larger (4mb)body-parserJSON limit, matching the AI prepare routes, so larger translation CSVs are not rejected by the default 100kb limit.Notes
file.text()+ JSON encoding is lossless.🤖 Generated with Claude Code