security: track quick-xml DoS advisories (RUSTSEC-2026-0194/0195)#2248
Open
aeonframework wants to merge 1 commit into
Open
security: track quick-xml DoS advisories (RUSTSEC-2026-0194/0195)#2248aeonframework wants to merge 1 commit into
aeonframework wants to merge 1 commit into
Conversation
Both rust-s3 0.37.2 (crates.io) and the aws-creds fork pin quick-xml 0.38.4, which is affected by two publicly disclosed advisories: - RUSTSEC-2026-0194: O(N^2) CPU amplification on malformed XML attribute values - RUSTSEC-2026-0195: Unbounded memory growth from deeply-nested XML elements The fix requires quick-xml >=0.40.0. A Cargo [patch.crates-io] cannot bridge the semver-incompatible bump without recompile errors; the remediation must come from rust-s3 upstream (durch/rust-s3) and be mirrored into the tlongwell-block fork. Exploitability in buzz is limited to S3 API response parsing, which uses a trusted operator-controlled endpoint. Risk arises only if the S3 layer is compromised or MITM'd. This commit adds a tracking comment so the dep pin is not silently reverted before the fix lands. Remove it once aws-creds is updated to a quick-xml >=0.40 revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated dependency audit flagged two publicly disclosed advisories affecting
quick-xml 0.38.4, which enters the workspace transitively viarust-s3 0.37.2and theaws-credsfork pinned in[patch.crates-io].Both are fixed in
quick-xml ≥ 0.40.0.Exploitability in buzz
quick-xmlis reached only via S3 API response parsing (ListBucket,GetObject, multipart XML). In production, the S3 endpoint is operator-controlled (theS3_ENDPOINTenv var) and trusted. The risk window is narrow: an attacker would need to MITM the S3 connection or compromise the storage backend to deliver malicious XML to the parser. Severity is HIGH in isolation but LOW in the current threat model.Why this PR cannot include the fix
quick-xml 0.40.0is a semver-incompatible bump from the^0.38pin inrust-s3. A[patch.crates-io]override pointing toquick-xml 0.40.xwill not compile becauserust-s3's XML parsing code uses the 0.38 API surface. The fix must come fromrust-s3itself:durch/rust-s3): bumpquick-xmlto^0.40and release a new crate version.tlongwell-block/rust-s3): mirror that bump and advance therevpin in[patch.crates-io]here.This PR
Adds a
# SECURITY TRACKINGcomment inCargo.tomladjacent to the existing fork pin, explaining the vulnerability, exploitability assessment, and exact remediation path. This prevents the comment from being lost if the patch block is touched for unrelated reasons.References