Limit logo and vehicle images to 400px - #4100
Open
Daniiiil1 wants to merge 1 commit into
Open
Conversation
Daniiiil1
marked this pull request as ready for review
August 7, 2026 12:30
patrickelectric
requested changes
Aug 7, 2026
| }) | ||
| this.loadImages() | ||
| }, | ||
| async resizeImage(file: File): Promise<Blob> { |
Member
There was a problem hiding this comment.
we probably should use browser-image-compression over doing all this.
Member
|
I would suggest investigating if 400px is the correct number, taking 4K screens into consideration. The way that I see, the main problem is not the resolution/dimensions, but the image size, aspect ratio, and the way it's being rendered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents oversized custom branding images from being stored and rendered by BlueOS.
Closes #3987
Validation