iOS support for C++ API (no Swift bindings yet)#801
Conversation
|
cmake changes look ok to me but I cannot test them myself |
|
could you add verification of it into github actions pipelines? |
|
anu updates? |
|
Thanks for reminder, I'll add the GitHub action pipeline and it should be ready to merge. |
Add GitHub action pipeline for ios
|
This should also be ready for review now @Andrey1994 - again, @calebkuitenbrouwer has added the GitHub Action for iOS C++ build. Let us know if anything still needs work. |
Andrey1994
left a comment
Andrey1994
left a comment
There was a problem hiding this comment.
my main question about this change what is the plan going forward?
as is it builds libs but for appstore/ios/etc should all of it be packed as XCFramework? should it be one XCFramework per compiled library?
| run: | | ||
| cmake -B build \ | ||
| -DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/ios.toolchain.cmake \ | ||
| -DPLATFORM=SIMULATORARM64 \ |
There was a problem hiding this comment.
its simulator only, for real devices it should be OS64, is the intent of this file just to check that its built and not to distribute compiled libs?
3 participants
Currently under test. In draft until all changes are verified.