Skip to content

fix: trigger duplicate interactive login prompts when logged out#400

Merged
stephahart merged 1 commit into
mainfrom
BREV-9425/logout-triggring-duplicate-prompt
Jun 11, 2026
Merged

fix: trigger duplicate interactive login prompts when logged out#400
stephahart merged 1 commit into
mainfrom
BREV-9425/logout-triggring-duplicate-prompt

Conversation

@vivansh12

@vivansh12 vivansh12 commented May 20, 2026

Copy link
Copy Markdown
Contributor

Problem : brev copy, brev shell, and brev port-forwardtriggered multiple interactive login prompts when the access token was missing or expired. Parallel auth requests from command initialization and workspace resolution competed for stdin, causing login failures with a “declined to login” error.

Fix: Acquire the access token once, synchronously, at the start of each command before launching any concurrent work. If the user is logged out, the interactive login runs a single time; subsequent command flows share the same cached token.

@vivansh12 vivansh12 requested a review from a team as a code owner May 20, 2026 10:06
@vivansh12 vivansh12 self-assigned this May 20, 2026
@vivansh12 vivansh12 force-pushed the BREV-9425/logout-triggring-duplicate-prompt branch from 58779d6 to b4f1de4 Compare May 25, 2026 08:01
@stephahart stephahart merged commit 49698e6 into main Jun 11, 2026
9 checks passed
@stephahart stephahart deleted the BREV-9425/logout-triggring-duplicate-prompt branch June 11, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants