Add support for lowering directly from Bytes.#13366
Queued
sunfishcode wants to merge 5 commits into
Queued
Conversation
Add a "component-model-bytes" feature which enables implementations of `ComponentType` and `Lower` for the `Bytes` type, from the `bytes` crate. These will allow optimizing functions that return `list<u8>` to return `Bytes` values without converting them to `Vec<u8>` first.
pchickey
approved these changes
May 14, 2026
Contributor
There was a problem hiding this comment.
Thanks. This would be a nice optimization to apply to wasmtime-wasi-io by default, in a follow up PR. As of now, it gets no CI testing, idk if we should add something for it in this PR or just count on it being tested via wasmtime-wasi-io in a follow up?
github-actions
Bot
added
the
wasmtime:api
* Consolidate `component-model-async-bytes` feature into `component-model-bytes` * Reformat `Cargo.toml` a bit * Add some basic tests that `Bytes` and `BytesMut` can be used.
alexcrichton
requested review from
dicej and
fitzgen
and removed request for
a team
Member
|
@pchickey mind reviewing the changes I've pushed up here? |
pchickey
approved these changes
Jun 3, 2026
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Tweaks and tests look good, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "component-model-bytes" feature which enables implementations of
ComponentTypeandLowerfor theBytestype, from thebytescrate.These will allow optimizing functions that return
list<u8>to returnBytesvalues without converting them toVec<u8>first.Zulip thread: #wasmtime > Optimizing `list<u8>` returns in hostcalls @ 💬