Fix broken test after #877 merge#918
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
===========================================
+ Coverage 37.87% 88.28% +50.41%
===========================================
Files 88 88
Lines 5025 5028 +3
Branches 0 642 +642
===========================================
+ Hits 1903 4439 +2536
+ Misses 3122 444 -2678
- Partials 0 145 +145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I'd merged #877 without merging in the changes from main, leading to a broken test in
test_estimators_match_expected. This PR is a quick fix for that, it removes the type checking objects once they are no longer needed so that they don't leak into the public API.Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Narrow import/cleanup changes in package init with no runtime behavior change beyond restoring expected public exports.
Overview
Cleans up
chainladder/__init__.pyso typing-only imports and helpers no longer appear on the package namespace after the #877 typing work.AnyandLiteralare imported only underTYPE_CHECKING, thenTYPE_CHECKING,annotations, andoverloadare removed from the module after use. The deprecation warning string is renamed to_option_warningso it is not treated as public API.Reviewed by Cursor Bugbot for commit abd3dda. Bugbot is set up for automated code reviews on this repo. Configure here.