sync#920
Merged
Merged
Conversation
Emit DeprecationWarning when the cupy backend is selected, without removing functionality: - Options.set_option warns for ARRAY_BACKEND='cupy' and for 'cupy' in ARRAY_PRIORITY. - Common.set_backend warns when backend='cupy'. Adds tests asserting the warnings fire and that non-cupy backends do not warn.
Move the DeprecationWarning to set_backend's public entry point and add a private _warn guard so internal recursive (inplace) and deep-child calls do not re-warn. This makes stacklevel=2 point at the user's call site and ensures exactly one warning fires. Strengthens the test to assert a single warning at the caller's file.
…nto #902_-friedland_gl_insurer_claims_data
Docs-only; no runtime, config, or public API changes. Clean-up Deletes the 36 .rst stub files under docs/library/generated/. Adds docs/library/generated/ to .gitignore, mirroring the existing docs/modules/generated/ entry one line above. These files are emitted by sphinx.ext.autosummary on every docs build (autosummary_generate = True in docs/conf.py, driven by the eight :toctree: generated/ directives in docs/library/api.md), so committing them is redundant and the committed copies drift out of sync with what Sphinx actually produces. Adds custom sphinx.ext.autosummary templates under docs/_templates/autosummary/: class.rst, class_inherited.rst, function.rst. API class pages now list own methods inline, and inherited methods in a summary table (via Jinja logic in the templates) Fixes the :template: names in docs/library/api.md to drop .rst (:template: class.rst → :template: class). Sets numpydoc_show_class_members = False and templates_path = ['_templates'] in docs/_config.yml (and the generated docs/conf.py). Guards docs/_ext/linkcode.py against property objects so inline members don't crash the build. properties since removed. will keep this redundancy in place Misc docstring bug fixes, from doctest warnings
…_data #902 friedland gl insurer claims data
…nto #789_doctest_to_codecov
#789 doctest to codecov
Deprecate cupy array backend (#843)
# Conflicts: # chainladder/__init__.py # chainladder/utils/tests/test_utilities.py
* adding support for multi_index * fixing test
henrydingliu
requested review from
genedan,
jbogaardt and
kennethshsu
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental #920 +/- ##
================================================
+ Coverage 88.08% 88.28% +0.20%
================================================
Files 87 88 +1
Lines 5035 5028 -7
Branches 658 642 -16
================================================
+ Hits 4435 4439 +4
+ Misses 449 444 -5
+ Partials 151 145 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Explicit imports may break callers that relied on leaked submodule names on
import chainladder; bootstrap index labeling changes simulation triangle metadata for multi-index inputs.Overview
This PR tightens the public API by replacing wildcard
import *with explicit exports and__all__on subpackages, and addstest_public_api.pyso curated names stay stable and implementation modules (e.g.mack,glm) no longer appear onchainladder.cl.optionsgains a pandas-stylepatargument (with deprecatedoption=), a workingdescribe_option()(regex / pipe patterns, doctest examples), and deprecation warnings when selectingcupyvia options orTriangle.set_backend('cupy').BootstrapODPSamplenow labels bootstrap output with aSimulation_#index, including multi-index triangles (new test). CI installs docs extras for unit tests, runs doctest coverage undercoverage run, and uploadscoverage-doctest.xml. A new bundled samplefriedland_gl_self_insureris registered in the manifest;uv.lockdrops directnumbafrom the package deps and bumpsnumpyconstraint wording.Reviewed by Cursor Bugbot for commit 8a4f172. Bugbot is set up for automated code reviews on this repo. Configure here.