#919 friedland gl self insurer grain#921
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 88.28% 88.28%
=======================================
Files 88 88
Lines 5028 5029 +1
Branches 642 642
=======================================
+ Hits 4439 4440 +1
Misses 444 444
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| __dt64_unit__, | ||
| __dt64_dtype__ | ||
| ) | ||
| from chainladder import __dt64_unit__, __dt64_dtype__ |
There was a problem hiding this comment.
someone's linter at it again
There was a problem hiding this comment.
Man I hate this... We basically have a competing linter...
There was a problem hiding this comment.
@genedan @henrydingliu what linter are you using? Can we just use the same one? x.x
Are you all on ruff?
There was a problem hiding this comment.
black. but i rarely turn it on
There was a problem hiding this comment.
I'm using black too, and mine is apply on save lol
Summary of Changes
Now the valuation date format is explicit
Related GitHub Issue(s)
Fixes #919
Additional Context for Reviewers
N/A
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Localized sample-loader and manifest metadata change; only one bundled dataset gets a new format string, with no auth or core algorithm changes.
Overview
Fixes incorrect development/valuation grain for the friedland_gl_self_insurer sample by wiring optional
development_formatthrough the sample manifest intoload_sample→Triangle.The manifest gains an optional
development_formatfield (documented in_manifest.py). Only friedland_gl_self_insurer sets it to%Y-12-31, so calendar-year development columns are parsed as explicit year-end dates instead of being inferred ambiguously.load_samplereadsconfig.get("development_format")and passes it when constructing the triangle.Minor cleanup in
utility_functions: import formatting and a small simplification ofdate_delta_adjustment(no behavior change intended).Reviewed by Cursor Bugbot for commit 3993b4a. Bugbot is set up for automated code reviews on this repo. Configure here.