Skip to content

#919 friedland gl self insurer grain#921

Merged
kennethshsu merged 2 commits into
mainfrom
#919_-friedland_gl_self_insurer_grain
Jun 4, 2026
Merged

#919 friedland gl self insurer grain#921
kennethshsu merged 2 commits into
mainfrom
#919_-friedland_gl_self_insurer_grain

Conversation

@kennethshsu
Copy link
Copy Markdown
Collaborator

@kennethshsu kennethshsu commented Jun 4, 2026

Summary of Changes

Now the valuation date format is explicit

Related GitHub Issue(s)

Fixes #919

Additional Context for Reviewers

N/A

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Localized sample-loader and manifest metadata change; only one bundled dataset gets a new format string, with no auth or core algorithm changes.

Overview
Fixes incorrect development/valuation grain for the friedland_gl_self_insurer sample by wiring optional development_format through the sample manifest into load_sampleTriangle.

The manifest gains an optional development_format field (documented in _manifest.py). Only friedland_gl_self_insurer sets it to %Y-12-31, so calendar-year development columns are parsed as explicit year-end dates instead of being inferred ambiguously. load_sample reads config.get("development_format") and passes it when constructing the triangle.

Minor cleanup in utility_functions: import formatting and a small simplification of date_delta_adjustment (no behavior change intended).

Reviewed by Cursor Bugbot for commit 3993b4a. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.28%. Comparing base (8a4f172) to head (3993b4a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files          88       88           
  Lines        5028     5029    +1     
  Branches      642      642           
=======================================
+ Hits         4439     4440    +1     
  Misses        444      444           
  Partials      145      145           
Flag Coverage Δ
unittests 88.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

__dt64_unit__,
__dt64_dtype__
)
from chainladder import __dt64_unit__, __dt64_dtype__
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone's linter at it again

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man I hate this... We basically have a competing linter...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genedan @henrydingliu what linter are you using? Can we just use the same one? x.x

Are you all on ruff?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black. but i rarely turn it on

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using black too, and mine is apply on save lol

@kennethshsu kennethshsu merged commit 31b3432 into main Jun 4, 2026
17 checks passed
@kennethshsu kennethshsu deleted the #919_-friedland_gl_self_insurer_grain branch June 4, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

friedland_gl_self_insurer is showing that has valuation of 01/31/2008 instead of 12/31/2008

2 participants