fix(tools): harden Grep format_output for local-model searches JSON#549
Closed
JessicaMulein wants to merge 1 commit into
Closed
fix(tools): harden Grep format_output for local-model searches JSON#549JessicaMulein wants to merge 1 commit into
JessicaMulein wants to merge 1 commit into
Conversation
Coerce double-encoded or malformed searches strings via parse_tool_arguments so format_output no longer crashes when qwen emits truncated inner JSON. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden Grep
format_outputandexecutewhen local models emit double-encoded or malformedsearchesJSON (truncated inner JSON, string instead of list)._coerce_searches()and route throughparse_tool_argumentstests/tools/test_tool_arguments.pyContext
Reopened from Digital-Defiance/cecli#12 (rebased on
cecli-dev/main).Test plan
pytest tests/tools/test_tool_arguments.py -k grep— 3 passed (local run)