Skip to content

Remove unused olm-bundle module - #653

Open
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:remove-olm-bundle
Open

Remove unused olm-bundle module#653
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:remove-olm-bundle

Conversation

@erikgb

@erikgb erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member

This module was probably used when we were publishing OLM bundles, but is not in use anymore in un-archived projects: https://github.com/search?q=org%3Acert-manager%20olm-bundle&type=code.

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 21, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 21, 2026
@erikgb

erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

/cc @inteon

@cert-manager-prow
cert-manager-prow Bot requested a review from inteon June 21, 2026 16:06
@inteon

inteon commented Jun 24, 2026

Copy link
Copy Markdown
Member

I agree with the change, but we currently still use this internally.
Will see what I can do this clean this up there.

@erikgb

erikgb commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

I agree with the change, but we currently still use this internally. Will see what I can do this clean this up there.

Ok, in that case, we can leave it for now. I will create an alternative PR to update/fix the go.sum file. And leave this open until you have resolved your on-prem usage.

@erikgb erikgb mentioned this pull request Jun 24, 2026
@cert-manager-prow cert-manager-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2026
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb
erikgb force-pushed the remove-olm-bundle branch from 7cab1bd to d6b7174 Compare August 13, 2026 11:05
@cert-manager-prow cert-manager-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2026
@erikgb
erikgb requested a lite review from Copilot August 13, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused olm-bundle makefile module and its associated boilerplate/assets, reducing maintenance surface now that OLM bundle publishing is no longer in use.

Changes:

  • Deletes the olm-bundle makefile module (00_mod.mk, 01_mod.mk) and its bundle-generation/publish targets.
  • Removes the olm-to-oci helper Go tool and its Go module files.
  • Removes OLM bundle base templates and related formatting config.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/olm-bundle/yamlfmt.yaml Removes module-specific YAML formatting configuration.
modules/olm-bundle/olm-to-oci/main.go Removes the OLM-bundle-to-OCI conversion helper tool.
modules/olm-bundle/olm-to-oci/go.sum Removes dependency lockfile for the deleted tool.
modules/olm-bundle/olm-to-oci/go.mod Removes the Go module definition for the deleted tool.
modules/olm-bundle/base/PROJECT Removes operator-sdk project scaffold used by the module.
modules/olm-bundle/base/bundle/README.md Removes documentation for the deleted OLM bundle boilerplate.
modules/olm-bundle/01_mod.mk Removes the module implementation: bundle generation, OCI build, and publish/scan targets.
modules/olm-bundle/00_mod.mk Removes the module configuration/variables and project generation target.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants