Remove unused olm-bundle module - #653
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @inteon |
|
I agree with the change, but we currently still use this internally. |
Ok, in that case, we can leave it for now. I will create an alternative PR to update/fix the go.sum file. And leave this open until you have resolved your on-prem usage. |
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
7cab1bd to
d6b7174
Compare
There was a problem hiding this comment.
Pull request overview
Removes the unused olm-bundle makefile module and its associated boilerplate/assets, reducing maintenance surface now that OLM bundle publishing is no longer in use.
Changes:
- Deletes the
olm-bundlemakefile module (00_mod.mk,01_mod.mk) and its bundle-generation/publish targets. - Removes the
olm-to-ocihelper Go tool and its Go module files. - Removes OLM bundle base templates and related formatting config.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/olm-bundle/yamlfmt.yaml | Removes module-specific YAML formatting configuration. |
| modules/olm-bundle/olm-to-oci/main.go | Removes the OLM-bundle-to-OCI conversion helper tool. |
| modules/olm-bundle/olm-to-oci/go.sum | Removes dependency lockfile for the deleted tool. |
| modules/olm-bundle/olm-to-oci/go.mod | Removes the Go module definition for the deleted tool. |
| modules/olm-bundle/base/PROJECT | Removes operator-sdk project scaffold used by the module. |
| modules/olm-bundle/base/bundle/README.md | Removes documentation for the deleted OLM bundle boilerplate. |
| modules/olm-bundle/01_mod.mk | Removes the module implementation: bundle generation, OCI build, and publish/scan targets. |
| modules/olm-bundle/00_mod.mk | Removes the module configuration/variables and project generation target. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This module was probably used when we were publishing OLM bundles, but is not in use anymore in un-archived projects: https://github.com/search?q=org%3Acert-manager%20olm-bundle&type=code.