Pin credentialed periodics to the dedicated node pool - #1228
Open
wallrj wants to merge 1 commit into
Open
Conversation
Any periodic carrying a credential preset now gets a nodeSelector and toleration for the dedicated=credentialed-jobs node pool, injected in Periodics — the single point through which every generated periodic passes — so no generator can accidentally schedule a credentialed job onto the shared worker pool, where presubmits run unreviewed PR code in privileged (dind) pods and can poison the node-local hostPath build caches. The pool itself is added by cert-manager/infrastructure#89. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
cert-manager-prow
Bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/hold Until cert-manager/infrastructure#89 is merged and applied; the nodeSelector matches no node until the pool exists. |
cert-manager-prow
Bot
added
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins every periodic which carries a credential preset (currently the
*-issuers-venafiperiodics on master, release-1.20 and release-1.21) to the dedicateddedicated=credentialed-jobsnode pool added by cert-manager/infrastructure#89, by injecting the matchingnodeSelectorand toleration in prowgen'sPeriodics()— the single point through which every generated periodic passes. This mirrors the shape of the presubmit credential guard inaddPresubmit(): the next generated credentialed job cannot silently land back on the shared worker pool, where presubmits run unreviewed PR code in privileged (dind) pods and can poison the node-local hostPath build caches.The taint key/value contract is defined in cert-manager/infrastructure
gcp/modules/gcp-cluster/main.tf; the comment oncredentialPresetsinpkg/context.gopoints there.Verified with
go test ./...,make verify(regenerated output matches the committed files) and prowcheckconfig --strict(passes).Hold until infrastructure#89 is merged and applied: until the node pool exists, the injected
nodeSelectormatches no node and the Venafi periodics would sit Pending.with claude fable-5