fix: Rerun the full securejoin protocol if the address was outdated#8358
Merged
Conversation
…heir singular relay and added a new one and then perform a securejoin
…a message actually works
…ropped their singular relay and added a new one and then perform a securejoin" This reverts commit a9d19bc.
Hocuri
changed the title
link2xt
reviewed
Jun 22, 2026
| Contact { | ||
| contact_id: ContactId, | ||
| fingerprint: Fingerprint, | ||
| addr: String, |
Collaborator
There was a problem hiding this comment.
QrInvite is serialized into the database, so this addr should likely be passed next to the QrInvite as a separate argument.
Collaborator
There was a problem hiding this comment.
Or you need to put #[serde(default)] on it for when it is deserialized from the bob state table.
Hocuri
commented
Jun 23, 2026
iequidoo
approved these changes
Jun 23, 2026
iequidoo
left a comment
iequidoo
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks easy to read, but link2xt's comment looked unobvious for me
hpk42
approved these changes
Jun 23, 2026
hpk42
left a comment
hpk42
left a comment
Contributor
There was a problem hiding this comment.
lgtm, also maybe make sense to to generate multi-address invite links soon.
link2xt
reviewed
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #8355, fixes #8329