refactor: improve comment#8366
Merged
Merged
Conversation
It's unclear whether this logic works, but I think we should at least properly document why it exists (I already sent this text while figuring out what the code does, so it was easy making this PR now) Could add a XXX note that it's unsure whether this works
link2xt
reviewed
Jun 25, 2026
link2xt
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unclear whether this logic works, but I think we should at least properly document why it exists (I already sent this text while figuring out what the code does, so it was easy making this PR now)
Could add a XXX note that it's unsure whether this works