Add support for direct file access to external storage#201
Merged
Conversation
chenxiaolong
force-pushed
the
saf
branch
9 times, most recently
from
c97938c to
06f9001
Compare
The local storage permissions we already request also grant access to external storage devices on Android 11 and newer. This commit add support for selecting files on external storage via the local folder picker and removes all code that assumes local paths are on internal storage. Other changes: * The messaging around storage types is now direct file access vs. storage access framework, instead of internal vs. external. The latter didn't make much sense anyway since the local storage permission allows access to external storage and SAF can be used to pick internal storage directories. * The local folder picker now watches for inotify events of the cwd and also external storage mount/unmount events. * The file conflict screen now properly opens directories for external storage local paths and SAF trees. stbridge no longer conflates paths for the two filesystem types when reporting conflicts to the main app. * The SAF picker now opens to the initial directory properly when granting SAF permissions after an import. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Jul 10, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local storage permissions we already request also grant access to external storage devices on Android 11 and newer. This commit add support for selecting files on external storage via the local folder picker and removes all code that assumes local paths are on internal storage.
Other changes:
The messaging around storage types is now direct file access vs. storage access framework, instead of internal vs. external. The latter didn't make much sense anyway since the local storage permission allows access to external storage and SAF can be used to pick internal storage directories.
The local folder picker now watches for inotify events of the cwd and also external storage mount/unmount events.
The file conflict screen now properly opens directories for external storage local paths and SAF trees. stbridge no longer conflates paths for the two filesystem types when reporting conflicts to the main app.
The SAF picker now opens to the initial directory properly when granting SAF permissions after an import.