[WIP] Add a Vite-based manual test server#1374
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b3181e5. Configure here.
| */ | ||
| const appElement = document.querySelector<HTMLElement>( '#app' )!; | ||
|
|
||
| renderApp( appElement, manualTestEntries ); |
There was a problem hiding this comment.
Catalog misses refresh prompt
Medium Severity
The test catalog entry never listens for ckeditor5-manual:refresh-available, while refreshPlugin suppresses normal HMR for non-CSS changes. After manual tests are added or removed, the index can keep a stale virtual:ckeditor5-manual-entries list with no refresh prompt, unlike wrapped manual pages.
Reviewed by Cursor Bugbot for commit b3181e5. Configure here.
|
|
||
| export function manualTestsPlugin( manualTestPatterns: Array<string> ): Plugin { | ||
| let workspaceRoot = process.cwd(); | ||
| const manualPagePatterns = manualTestPatterns.map( pattern => `${ pattern }.{html,js,md,ts}` ); |
There was a problem hiding this comment.
Glob suffix breaks extension patterns
Medium Severity
manualTestsPlugin always appends .{html,js,md,ts} to each configured glob. Patterns that already include those extensions (for example **/*.{html,js,md,ts}) become invalid and match no manual page files, leaving the catalog empty despite tests on disk.
Reviewed by Cursor Bugbot for commit b3181e5. Configure here.
1 participant
🚀 Summary
Add a Vite-based manual test server.
📌 Related issues
💡 Additional information
Still WIP.