test(ui): Add snapshot tests for SignInStartView#8658
Draft
alexcarpenter wants to merge 3 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: fff994b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexcarpenter
force-pushed
the
prop-driven-factor-two
branch
from
52ae651 to
282455e
Compare
SignInStartView is already prop-driven (no context hooks). Adds 8 snapshot tests covering loading, email form, password field, combined flow, waitlist, restricted mode, card error, and passkey button states. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reducer now returns just state, not { state, effects }. Side-effect
decisions extracted into pure testable functions (routeSignInStatus,
classifySubmitError). Effect execution moved to async handlers in the
hook (handleSignInCreate, handleTicketFlow). Removed identifierValue
and passwordValue from reducer state — form controls own their values
directly. Updated tests to verify pure functions independently.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexcarpenter
force-pushed
the
sign-in-start-cleanup
branch
from
b7cf980 to
fff994b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SignInStartView, which is already a pure-props component (no context hooks).stubFormControlhelper for creating mockFormControlStateobjects in snapshot tests.signInStartMachine.tsis already well-tested (30+ test cases) and makes the reducer fully testable as a pure function. Removing it would regress testability.Stacked on #8657.
Test plan
🤖 Generated with Claude Code