fix(tanstack-ai): omit empty Workers AI tools arrays - #608
Open
morgan-coded wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: fd2ee23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
The three workflow runs on fd2ee23 (CI, Prerelease, Semgrep OSS scan) are all Scope is one package: @cloudflare/tanstack-ai omits the tools array from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cloudflare/tanstack-aicould passtools: []to Workers AI, which some vLLM-backed models reject. This omits those empty arrays from the direct binding and Workers AI gateway paths, while non-empty tools and other providers stay unchanged. I checked the red/green cases, then ran the package suite, typecheck, build, lint, format, and the affected targets. Fixes #577