Draft 09 conformance & 413 fix

[HenriqueSFernandes]

What was done:

• Aggregation formula: the two sub-scores were combined with the draft-03 harmonic form; draft-09 converts each to RPM first and averages, so the old form could only under-report.
• Foreign probe timing: tcp_f/tls_f/http_f were measured cumulatively from before DNS instead of as three independent round-trips, roughly doubling the foreign RTT and halving the RPM.
• TLS round-trip normalization: was missing; handshake time is now divided by the round-trips the negotiated version takes (1.3 = 1, 1.2 = 2).
• Connection error handling: there was none, and HTTP status was never checked, so a 413 counted as a successful transfer: against a local 10 MiB body cap the upload leg reported 952 RPM against an honest ~335. Added --on-connection-error {retire,abort}.
• Bounded upload requests: upload load was a single unbounded 32 GiB POST, which servers might reject with 413 once it passes their body cap, killing the load mid-run and leaving the score artificially high. Now an open-ended sequence of bounded POSTs re-issued on the same connection, via --upload-max-request-bytes (default 100 MB).
• No more 0 RPM on healthy runs: the reported value came from a wall-clock window that the newest sample sat exactly on the edge of; 1 run in 14 matched nothing and reported 0. Reporting is now clock-free.
• --insecure: for testing against a local proxy with a self-signed certificate.

[Copilot]

Pull request overview

Aligns the responsiveness (RPM) measurement implementation with draft-ietf-ippm-responsiveness-09 and fixes biased/incorrect results caused by cumulative foreign timing, missing TLS normalization, and treating HTTP 413 / connection failures as “successful” load.

Changes:

• Update RPM computation to draft-09 semantics (RPM-per-side then arithmetic mean), fix foreign probe phase accounting, normalize TLS handshake by TLS round-trips, and avoid “0 RPM” from wall-clock windowing.
• Make upload load generation robust to per-request body caps by reissuing bounded POSTs on the same connection; surface/handle failed load-generating connections via a configurable policy.
• Add CLI/config/reporting support for --upload-max-request-bytes, --on-connection-error, --insecure, and expose degraded results via failed_connections / optional RPM.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/nq-rpm/src/lib.rs	Draft-09 RPM formula, foreign timing fixes, error-policy handling, and RPM reporting semantics (Option).
crates/nq-packetloss/src/lib.rs	Removes upload-size configuration tied to the old unbounded upload model.
crates/nq-load-generator/src/lib.rs	Implements bounded upload request reissue + failure detection/state tracking for load connections.
crates/nq-core/src/lib.rs	Re-exports new core types/helpers (InflightBody, insecure TLS toggles).
crates/nq-core/src/connection/mod.rs	Adds TLS round-trip tracking + TCP/TLS phase helpers on ConnectionTiming.
crates/nq-core/src/connection/http.rs	Adds global --insecure TLS verification bypass and HTTP/1.1 request normalization.
crates/nq-core/src/client.rs	Adds upload/download status checking, propagates failures via BodyEvent::Failed, and corrects timing start (post-DNS).
crates/nq-core/src/body/mod.rs	Expands InflightBody fields and semantics for event channel closure.
crates/nq-core/src/body/counting_body.rs	Adds BodyEvent::Failed + sender handle for out-of-band failure reporting with tests.
cli/src/up_down.rs	Wires --insecure into up/down commands.
cli/src/rpm.rs	Wires new RPM CLI knobs, adds degraded-result warnings, and passes new config fields through.
cli/src/report.rs	Treats absent RPM as an error (not zero) and serializes failed connection count.
cli/src/args/up_down.rs	Adds --insecure flag to upload/download args.
cli/src/args/rpm.rs	Adds --on-connection-error and --upload-max-request-bytes parsing/validation plus defaults.
cli/src/aim_report.rs	Maintains telemetry compatibility by flattening missing RPM to 0.0 with explicit rationale.

Suppressed comments (1)

crates/nq-load-generator/src/lib.rs:312

• This error message also reports the wrong request number (it uses the count of requests already started, but the failure occurred while starting the next request).

                    let _ = events_tx.send(BodyEvent::Failed {
                        at: self.time.now(),
                        reason: format!("upload request {requests} failed to start: {error:#}"),
                    });
                    return;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.