Skip to content

Pass jwt signing key to consumers#515

Merged
aramprice merged 1 commit into
developfrom
add-jwt-signer
Jul 17, 2026
Merged

Pass jwt signing key to consumers#515
aramprice merged 1 commit into
developfrom
add-jwt-signer

Conversation

@aramprice

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dd7e03b6-b27b-45c5-9a03-b8a8298c83c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-jwt-signer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the BOSH director’s config_server UAA configuration in the ops files so that the UAA JWT signing public key is explicitly provided alongside the existing client credentials. This supports consumers that need the UAA public key available in the director’s config-server/UAA settings.

Changes:

  • Add public_key: ((uaa_jwt_signing_key.public_key)) under /instance_groups/name=bosh/properties/director/config_server/uaa in misc/config-server.yml.
  • Add public_key: ((uaa_jwt_signing_key.public_key)) under /instance_groups/name=bosh/properties/director/config_server/uaa in credhub.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
misc/config-server.yml Passes UAA JWT public key into the director’s config-server UAA config for the config-server deployment scenario.
credhub.yml Passes UAA JWT public key into the director’s config-server UAA config for the CredHub-as-config-server scenario.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aramprice
aramprice merged commit ff0a765 into develop Jul 17, 2026
3 checks passed
@aramprice
aramprice deleted the add-jwt-signer branch July 17, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants