feat(greenhouse): visualize preset and plugin version#1807
Conversation
🦋 Changeset detectedLatest commit: d65d4c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Adds version visibility to the Greenhouse admin UI so operators can quickly identify which PluginDefinition version is deployed via PluginPresets, and which Helm chart (name/version) is backing a Plugin instance.
Changes:
- Extends the admin API schema types with
PluginPreset.status.pluginDefinitionVersion. - Adds a “Version” column/field to PluginPreset list and detail views, including mocks/tests.
- Displays
Plugin.status.helmChartname/version in the Plugin instance detail view, including tests.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/greenhouse/src/components/admin/types/schema.d.ts | Adds pluginDefinitionVersion to PluginPresetStatus typings. |
| apps/greenhouse/src/components/admin/PluginPresets/PluginPresetsDataGrid/index.tsx | Adds “Version” header and updates grid column counts. |
| apps/greenhouse/src/components/admin/PluginPresets/PluginPresetsDataGrid/index.test.tsx | Verifies “Version” column header and version value rendering. |
| apps/greenhouse/src/components/admin/PluginPresets/PluginPresetsDataGrid/DataRows/index.tsx | Renders preset.status.pluginDefinitionVersion in the new column. |
| apps/greenhouse/src/components/admin/PluginPresetDetail/Overview/Details.tsx | Adds “Version” field to preset detail view. |
| apps/greenhouse/src/components/admin/PluginPresetDetail/Overview/Details.test.tsx | Verifies preset detail renders pluginDefinitionVersion. |
| apps/greenhouse/src/components/admin/PluginInstanceDetail/Overview/Details.tsx | Adds Helm chart name/version fields to plugin instance detail view. |
| apps/greenhouse/src/components/admin/PluginInstanceDetail/Overview/Details.test.tsx | Verifies Helm chart name/version values render. |
| apps/greenhouse/src/components/admin/mocks/pluginPresets.ts | Adds mock pluginDefinitionVersion for list rendering/tests. |
|
I need to add version in the plugin list as well. Then I will test it in PR preview. |
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
On-behalf-of: @SAP krzysztof.zagorski@sap.com Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
|
I added Helm Chart Version to plugin lists (both from presets and clusters view). Added perses PluginPreset to QA so it shows proper versions in PR preview. |
Summary
Visualizes PluginDefinition versions in the Greenhouse dashboard so operators can quickly see which version is deployed where. Adds
PluginPreset.status.pluginDefinitionVersionto the PluginPreset list and PluginPreset detail, andPlugin.status.helmChartfields to the Plugin instance detail.Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm test— all existing and new unit tests passChecklist
PR Manifesto
Review the PR Manifesto for best practises.