Skip to content

feat(greenhouse): visualize preset and plugin version#1807

Open
Zaggy21 wants to merge 6 commits into
mainfrom
feat/visualize-preset-and-plugin-version
Open

feat(greenhouse): visualize preset and plugin version#1807
Zaggy21 wants to merge 6 commits into
mainfrom
feat/visualize-preset-and-plugin-version

Conversation

@Zaggy21

@Zaggy21 Zaggy21 commented Jul 3, 2026

Copy link
Copy Markdown

Summary

Visualizes PluginDefinition versions in the Greenhouse dashboard so operators can quickly see which version is deployed where. Adds PluginPreset.status.pluginDefinitionVersion to the PluginPreset list and PluginPreset detail, and Plugin.status.helmChart fields to the Plugin instance detail.

Changes Made

  • Add pluginDefinitionVersion to PluginPresetStatus in admin/types/schema.d.ts (synced from greenhouse#1996)
  • Add Version column to the PluginPreset list (after PluginDefinition column)
  • Add Version field to the PluginPreset detail (after PluginDefinition field)
  • Add Helm Chart and Helm Chart Version fields to the Plugin instance detail
  • Add Helm Chart Version column to the Plugin instance lists (PluginPreset detail and Cluster detail)

Related Issues

Screenshots (if applicable)

presets_list presets_details plugin_details

Testing Instructions

  1. pnpm i
  2. pnpm test — all existing and new unit tests pass
  3. Start the local dev environment (see greenhouse-local-dev guide) and navigate to /demo/plugin-presets to verify the Version column in the PP list, click a preset to verify the Version field in the PP detail, and click a plugin instance to verify the Helm Chart fields

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Zaggy21 added 3 commits July 2, 2026 16:35
…set list

On-behalf-of: @SAP krzysztof.zagorski@sap.com
Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
On-behalf-of: @SAP krzysztof.zagorski@sap.com
Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
On-behalf-of: @SAP krzysztof.zagorski@sap.com
Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
Copilot AI review requested due to automatic review settings July 3, 2026 13:08
@Zaggy21 Zaggy21 requested a review from a team as a code owner July 3, 2026 13:08
@changeset-bot

changeset-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d65d4c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds version visibility to the Greenhouse admin UI so operators can quickly identify which PluginDefinition version is deployed via PluginPresets, and which Helm chart (name/version) is backing a Plugin instance.

Changes:

  • Extends the admin API schema types with PluginPreset.status.pluginDefinitionVersion.
  • Adds a “Version” column/field to PluginPreset list and detail views, including mocks/tests.
  • Displays Plugin.status.helmChart name/version in the Plugin instance detail view, including tests.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/greenhouse/src/components/admin/types/schema.d.ts Adds pluginDefinitionVersion to PluginPresetStatus typings.
apps/greenhouse/src/components/admin/PluginPresets/PluginPresetsDataGrid/index.tsx Adds “Version” header and updates grid column counts.
apps/greenhouse/src/components/admin/PluginPresets/PluginPresetsDataGrid/index.test.tsx Verifies “Version” column header and version value rendering.
apps/greenhouse/src/components/admin/PluginPresets/PluginPresetsDataGrid/DataRows/index.tsx Renders preset.status.pluginDefinitionVersion in the new column.
apps/greenhouse/src/components/admin/PluginPresetDetail/Overview/Details.tsx Adds “Version” field to preset detail view.
apps/greenhouse/src/components/admin/PluginPresetDetail/Overview/Details.test.tsx Verifies preset detail renders pluginDefinitionVersion.
apps/greenhouse/src/components/admin/PluginInstanceDetail/Overview/Details.tsx Adds Helm chart name/version fields to plugin instance detail view.
apps/greenhouse/src/components/admin/PluginInstanceDetail/Overview/Details.test.tsx Verifies Helm chart name/version values render.
apps/greenhouse/src/components/admin/mocks/pluginPresets.ts Adds mock pluginDefinitionVersion for list rendering/tests.

@ArtieReus ArtieReus added the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Jul 8, 2026
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Jul 8, 2026
@github-actions github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Jul 10, 2026
@Zaggy21 Zaggy21 removed the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Jul 10, 2026
@ArtieReus ArtieReus added the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Jul 10, 2026
@Zaggy21

Zaggy21 commented Jul 10, 2026

Copy link
Copy Markdown
Author

I need to add version in the plugin list as well. Then I will test it in PR preview.

@Zaggy21 Zaggy21 removed the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Jul 10, 2026
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Jul 10, 2026
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
ArtieReus
ArtieReus previously approved these changes Jul 10, 2026
taymoor89
taymoor89 previously approved these changes Jul 10, 2026
On-behalf-of: @SAP krzysztof.zagorski@sap.com
Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
@Zaggy21 Zaggy21 dismissed stale reviews from taymoor89 and ArtieReus via d65d4c6 July 10, 2026 11:40
@Zaggy21 Zaggy21 added the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Jul 10, 2026
@Zaggy21

Zaggy21 commented Jul 10, 2026

Copy link
Copy Markdown
Author

I added Helm Chart Version to plugin lists (both from presets and clusters view). Added perses PluginPreset to QA so it shows proper versions in PR preview.

@Zaggy21 Zaggy21 requested a review from ArtieReus July 10, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] - Visualize PP and P version

5 participants