Skip to content

feat: allow multiple declarations of the same property in discriminat… - #120

Merged
avinashbot merged 3 commits into
cloudscape-design:mainfrom
shannenigans:main
Aug 3, 2026
Merged

feat: allow multiple declarations of the same property in discriminat…#120
avinashbot merged 3 commits into
cloudscape-design:mainfrom
shannenigans:main

Conversation

@shannenigans

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
Picks the first non-never property when multiple declarations are provided

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shannenigans
shannenigans requested a review from a team as a code owner July 27, 2026 21:09
@shannenigans
shannenigans requested review from ernst-dev and removed request for a team July 27, 2026 21:09
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.57%. Comparing base (b2851ce) to head (3ff74c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   95.11%   94.57%   -0.55%     
==========================================
  Files          11       11              
  Lines         512      516       +4     
  Branches      139      142       +3     
==========================================
+ Hits          487      488       +1     
- Misses         25       28       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ernst-dev

Copy link
Copy Markdown
Member

Could you add more tests to meet the codecov requirements?

Comment thread src/shared/type-utils.ts Outdated
Comment thread test/components/discriminated-union.test.ts Outdated
@avinashbot
avinashbot removed the request for review from ernst-dev August 3, 2026 14:35
@avinashbot
avinashbot self-requested a review August 3, 2026 15:09
@avinashbot
avinashbot enabled auto-merge August 3, 2026 15:25
@avinashbot
avinashbot added this pull request to the merge queue Aug 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 3, 2026
@avinashbot
avinashbot added this pull request to the merge queue Aug 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 3, 2026
@avinashbot
avinashbot added this pull request to the merge queue Aug 3, 2026
Merged via the queue into cloudscape-design:main with commit 5c84a54 Aug 3, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants