Skip to content

feat(quota-enforcement): split accept_skipped decision into sub-buckets #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umswmayj merged 1 commit into from
Jul 10, 2026
+25 −16
Merged

feat(quota-enforcement): split accept_skipped decision into sub-buckets #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions internal/scheduling/nova/plugins/filters/filter_quota_enforcement.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,43 +81,49 @@ func (s *FilterQuotaEnforcement) Run(traceLog *slog.Logger, request api.External
}

// Step 1: Skip intents that don't represent new resource consumption.
// We distinguish two sub-buckets in the decision label so operators can tell
// external non-consuming intents (evacuate / live-migrate — VM already exists,
// being moved) apart from cortex-internal reservation intents (failover /
// committed-resource reservations — new schedules driven by cortex itself).
intent, err := request.GetIntent()
if err == nil {
switch intent {
case api.EvacuateIntent, api.LiveMigrationIntent:
traceLog.Info("skipping quota enforcement for non-consuming intent", "intent", intent)
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped", "", "", "")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped_intent_migration", "", "", "")
return result, nil
case api.ReserveForFailoverIntent:
traceLog.Info("skipping quota enforcement for failover reservation intent")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped", "", "", "")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped_intent_internal", "", "", "")
return result, nil
case api.ReserveForCommittedResourceIntent:
// TODO: revisit whether committed resource reservation scheduling should also be quota-checked
traceLog.Info("skipping quota enforcement for committed resource reservation intent")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped", "", "", "")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped_intent_internal", "", "", "")
return result, nil
}
}

// Step 2: Extract project, AZ, and hw_version from the request.
// Missing-data skips share a single decision bucket; the specific missing
// field is in the trace log.
projectID := request.Spec.Data.ProjectID
az := request.Spec.Data.AvailabilityZone
hwVersion := request.Spec.Data.Flavor.Data.ExtraSpecs["hw_version"]

if projectID == "" {
traceLog.Warn("no project ID in request, skipping quota enforcement")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped", "", az, hwVersion)
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped_missing_data", "", az, hwVersion)
return result, nil
}
if az == "" {
traceLog.Warn("no availability zone in request, skipping quota enforcement")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped", "", "", hwVersion)
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped_missing_data", "", "", hwVersion)
return result, nil
}
if hwVersion == "" {
traceLog.Warn("no hw_version in flavor extra specs, skipping quota enforcement")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped", "", az, "")
QuotaEnforcementMetricsSingleton.RecordDecision(mode, "accept_skipped_missing_data", "", az, "")
return result, nil
}

Expand Down
5 changes: 4 additions & 1 deletion internal/scheduling/nova/plugins/filters/filter_quota_enforcement_metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ type QuotaEnforcementMetrics struct {
// produces. Labels:
// - mode: "enforce" | "shadow"
// - decision: "accept_cr" | "accept_payg" | "accept_no_quota" |
// "accept_skipped" | "reject"
// "accept_skipped_intent_migration" |
// "accept_skipped_intent_internal" |
// "accept_skipped_missing_data" |
// "reject"
// - resource: "ram" | "cores" | "instances" | "" (empty when
// the decision is not driven by a single resource)
// - availability_zone: AZ string or "" if unknown at decision time
Expand Down
18 changes: 9 additions & 9 deletions internal/scheduling/nova/plugins/filters/filter_quota_enforcement_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
// Metric expectations — every case asserts exactly one increment on the
// labeled series and exactly one series in the vector.
expectMode string // "enforce" | "shadow"
expectDecision string // accept_cr | accept_payg | accept_no_quota | accept_skipped | reject
expectDecision string // accept_cr | accept_payg | accept_no_quota | accept_skipped_intent_migration | accept_skipped_intent_internal | accept_skipped_missing_data | reject
expectResource string // "ram" | "cores" | "instances" | ""
expectAZ string
expectFG string
Expand Down Expand Up @@ -263,7 +263,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
expectAccept: true,
enforce: true,
expectMode: "enforce",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_intent_migration",
expectResource: "",
expectAZ: "",
expectFG: "",
Expand All @@ -276,7 +276,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
expectAccept: true,
enforce: true,
expectMode: "enforce",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_intent_migration",
expectResource: "",
expectAZ: "",
expectFG: "",
Expand All @@ -289,7 +289,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
expectAccept: true,
enforce: true,
expectMode: "enforce",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_intent_internal",
expectResource: "",
expectAZ: "",
expectFG: "",
Expand All @@ -302,7 +302,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
expectAccept: true,
enforce: true,
expectMode: "enforce",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_intent_internal",
expectResource: "",
expectAZ: "",
expectFG: "",
Expand All @@ -314,7 +314,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
expectAccept: true,
enforce: true,
expectMode: "enforce",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_missing_data",
expectResource: "",
expectAZ: "az-1",
expectFG: "",
Expand All @@ -326,7 +326,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
expectAccept: true,
enforce: true,
expectMode: "enforce",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_missing_data",
expectResource: "",
expectAZ: "az-1",
expectFG: "hana_v2",
Expand All @@ -338,7 +338,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
expectAccept: true,
enforce: true,
expectMode: "enforce",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_missing_data",
expectResource: "",
expectAZ: "",
expectFG: "hana_v2",
Expand Down Expand Up @@ -904,7 +904,7 @@ func TestFilterQuotaEnforcement_Run(t *testing.T) {
map[string]any{"_nova_check_type": "live_migrate"}),
expectAccept: true,
expectMode: "shadow",
expectDecision: "accept_skipped",
expectDecision: "accept_skipped_intent_migration",
expectResource: "",
expectAZ: "",
expectFG: "",
Expand Down