Skip to content

Integration test#263

Draft
fwiesel wants to merge 1 commit into
mainfrom
integration-test
Draft

Integration test#263
fwiesel wants to merge 1 commit into
mainfrom
integration-test

Conversation

@fwiesel

@fwiesel fwiesel commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@fwiesel fwiesel force-pushed the integration-test branch from 7daa16b to 3b2c26a Compare July 8, 2026 13:06
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c99bf5ea-e532-48c1-b0ca-a94ae3c515d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch integration-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fwiesel fwiesel changed the base branch from main to ssa July 8, 2026 13:49
@fwiesel fwiesel force-pushed the integration-test branch 3 times, most recently from e316477 to a702d5e Compare July 9, 2026 07:34
@fwiesel fwiesel changed the base branch from ssa to main July 9, 2026 07:35
@fwiesel fwiesel force-pushed the integration-test branch 2 times, most recently from 2b68fa5 to 0b1f38d Compare July 9, 2026 07:52
@fwiesel fwiesel changed the base branch from main to testable-controllers July 9, 2026 07:52
@fwiesel fwiesel force-pushed the testable-controllers branch from 8569ee9 to e43ceab Compare July 9, 2026 08:03
@fwiesel fwiesel force-pushed the integration-test branch 3 times, most recently from f9fa04d to 110d5e8 Compare July 9, 2026 10:27
End-to-end test that starts the full controller suite against a fake
OpenStack API and a real envtest Kubernetes API server. Asserts on
observable outcomes only:
- Hypervisor CRD creation from a lifecycle-labelled Node
- Nova service enabled with forced_down cleared
- Aggregates and traits applied to OpenStack
- Smoke-test VMs cleaned up
- Ready=True with Onboarding=False/Succeeded

The test simulates the external kvm-ha-service by polling for the
Handover phase and setting HaEnabled=True, since the operator itself
no longer owns HA enablement (a9e7332).
@fwiesel fwiesel force-pushed the integration-test branch from 110d5e8 to e57a8ec Compare July 9, 2026 17:38
@fwiesel fwiesel changed the base branch from testable-controllers to main July 9, 2026 17:38
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ Note: Baseline coverage from testable-controllers branch is not available (artifact may be expired). Showing current coverage for changed files only.

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/internal 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 72.17% (+72.17%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/aggregate.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/aggregategroup.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/capabilities.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/cell.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/domaincapabilities.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/eviction.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/evictionspec.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/evictionstatus.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/group.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisor.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorspec.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorstatus.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorupdatestatus.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/instance.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/operatingsystemstatus.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/traitgroup.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/internal/internal.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/aggregates_controller.go 87.69% (+87.69%) 65 (+65) 57 (+57) 8 (+8) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller.go 61.82% (+61.82%) 165 (+165) 102 (+102) 63 (+63) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller.go 80.68% (+80.68%) 88 (+88) 71 (+71) 17 (+17) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/offboarding_controller.go 74.29% (+74.29%) 70 (+70) 52 (+52) 18 (+18) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go 57.09% (+57.09%) 247 (+247) 141 (+141) 106 (+106) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/traits_controller.go 78.12% (+78.12%) 64 (+64) 50 (+50) 14 (+14) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/integration_mock_openstack_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/integration_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant