Hypervisor: Drop FieldOwner from Create#323
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe hypervisor reconciliation create call no longer passes ChangesHypervisor creation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The controller would become then the owner of all fields, including the defaults in spec, but they should just be the defaults.
142f93d to
4d5d3ec
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Drop the
FieldOwneroption from theCreatecall inHypervisorController. Field ownership is only meaningful forApply/Patch; passing it onCreateis a no-op that creates noise in managed-fields.Part of the branch stack being reorganized for reviewability. Independent of SSA migration — can be merged at any time.
Summary by CodeRabbit