Factor out Hypervisor compute-service enabling/disabling to own controller

[fwiesel]

Extracts the Nova compute-service enable/disable logic from HypervisorMaintenanceController into a dedicated HypervisorComputeServiceController. This separates the concerns of HA-state management (maintenance) from compute-service lifecycle.

Includes full unit tests for the new controller.

Depends on: ssa (#327).

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 707d1f2b-672d-4c37-a54d-bea4728be9e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch factor-out-hypervisor-disabled

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

⚠️ Note: Baseline coverage from ssa branch is not available (artifact may be expired). Showing current coverage for changed files only.

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1	0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd	0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller	69.16% (+69.16%)	🌟

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go	0.00% (ø)	0	0	0
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd/main.go	0.00% (ø)	0	0	0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_compute_service_controller.go	75.00% (+75.00%)	60 (+60)	45 (+45)	15 (+15)	🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller.go	76.92% (+76.92%)	52 (+52)	40 (+40)	12 (+12)	🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go	56.64% (+56.64%)	226 (+226)	128 (+128)	98 (+98)	🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

• github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_compute_service_controller_test.go
• github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller_test.go
• github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller_test.go