WIP: Add HypervisorConfigSet and HypervisorConfigOverride CRDs#329
Draft
fwiesel wants to merge 2 commits into
Draft
WIP: Add HypervisorConfigSet and HypervisorConfigOverride CRDs#329fwiesel wants to merge 2 commits into
fwiesel wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fwiesel
force-pushed
the
ssa
branch
2 times, most recently
from
4c09880 to
9d785cb
Compare
fwiesel
force-pushed
the
hypervisor-config-sets-and-override
branch
from
78b54fe to
aad77eb
Compare
fwiesel
force-pushed
the
hypervisor-config-sets-and-override
branch
from
aad77eb to
8fd5511
Compare
Standard Kubernetes label selector descriptions in generated CRD YAML use 'ANDed' (e.g. 'matchExpressions are ANDed'), which the typos checker flags as a misspelling of 'Dead'.
|
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress — not ready for review.
Introduces two new CRDs for per-hypervisor configuration management:
HypervisorConfigSet: a named template of config values that can be applied to a set of hypervisorsHypervisorConfigOverride: per-hypervisor overrides on top of a ConfigSetWires the override lookup into
HypervisorControllerso that per-node config values are resolved at reconcile time.Depends on:
ssa(#302).