Regenerate apply configurations with controller-gen v0.21.0#332
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (20)
📝 WalkthroughWalkthroughThis PR regenerates controller-gen apply-configurations and CRDs. It adds a ChangesGenerated apply-configuration and CRD updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Regenerates CRDs and server-side apply configuration code with controller-gen v0.21.0 to match CI output, including updated apply-configuration constructor signatures for cluster-scoped resources.
Changes:
- Regenerated CRDs with updated controller-gen version annotation (v0.21.0).
- Regenerated applyconfigurations, updating
Eviction()/Hypervisor()constructors to omitnamespacefor cluster-scoped resources. - Added/updated generated apply/extract helpers and schema metadata used for managed-fields extraction.
Reviewed changes
Copilot reviewed 2 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/openstack-hypervisor-operator/crds/kvm.cloud.sap_hypervisors.yaml | Regenerated Hypervisor CRD metadata with controller-gen v0.21.0 output. |
| charts/openstack-hypervisor-operator/crds/kvm.cloud.sap_evictions.yaml | Regenerated Eviction CRD metadata with controller-gen v0.21.0 output. |
| applyconfigurations/internal/internal.go | Updated structured-merge-diff schema used by managed-fields extraction for generated apply configs. |
| applyconfigurations/api/v1/hypervisor.go | Updated Hypervisor apply constructor signature (cluster-scoped) and added extract helpers. |
| applyconfigurations/api/v1/eviction.go | Updated Eviction apply constructor signature (cluster-scoped) and added extract helpers. |
| applyconfigurations/api/v1/hypervisorspec.go | Regenerated spec apply config; includes expanded doc comments. |
| applyconfigurations/api/v1/hypervisorstatus.go | Regenerated status apply config; includes expanded doc comments. |
| applyconfigurations/api/v1/hypervisorupdatestatus.go | Regenerated update status apply config with doc comments. |
| applyconfigurations/api/v1/operatingsystemstatus.go | Regenerated OS status apply config with doc comments. |
| applyconfigurations/api/v1/domaincapabilities.go | Regenerated domain capabilities apply config with doc comments. |
| applyconfigurations/api/v1/capabilities.go | Regenerated capabilities apply config with doc comments. |
| applyconfigurations/api/v1/cell.go | Regenerated cell apply config with doc comments. |
| applyconfigurations/api/v1/instance.go | Regenerated instance apply config with doc comments. |
| applyconfigurations/api/v1/group.go | Regenerated group apply config with doc comments. |
| applyconfigurations/api/v1/traitgroup.go | Regenerated trait group apply config with doc comments. |
| applyconfigurations/api/v1/aggregategroup.go | Regenerated aggregate group apply config with doc comments. |
| applyconfigurations/api/v1/aggregate.go | Regenerated aggregate apply config with doc comments. |
| applyconfigurations/api/v1/evictionspec.go | Regenerated eviction spec apply config with doc comments. |
| applyconfigurations/api/v1/evictionstatus.go | Regenerated eviction status apply config with doc comments. |
Files not reviewed (17)
- applyconfigurations/api/v1/aggregate.go: Generated file
- applyconfigurations/api/v1/aggregategroup.go: Generated file
- applyconfigurations/api/v1/capabilities.go: Generated file
- applyconfigurations/api/v1/cell.go: Generated file
- applyconfigurations/api/v1/domaincapabilities.go: Generated file
- applyconfigurations/api/v1/eviction.go: Generated file
- applyconfigurations/api/v1/evictionspec.go: Generated file
- applyconfigurations/api/v1/evictionstatus.go: Generated file
- applyconfigurations/api/v1/group.go: Generated file
- applyconfigurations/api/v1/hypervisor.go: Generated file
- applyconfigurations/api/v1/hypervisorspec.go: Generated file
- applyconfigurations/api/v1/hypervisorstatus.go: Generated file
- applyconfigurations/api/v1/hypervisorupdatestatus.go: Generated file
- applyconfigurations/api/v1/instance.go: Generated file
- applyconfigurations/api/v1/operatingsystemstatus.go: Generated file
- applyconfigurations/api/v1/traitgroup.go: Generated file
- applyconfigurations/internal/internal.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI installs controller-gen@latest which is now v0.21.0. The new version correctly omits the namespace parameter from apply configuration constructors for cluster-scoped resources (Hypervisor, Eviction). Also fixes grammatical errors in API type comments that propagate into CRD schema descriptions: - "request an reboot" -> "requests a reboot" - "request an evacuation" -> "requests an evacuation" - "Require to issue" -> "Requires issuing" - "enable the installations" -> "enable the installation" - "the take the following" -> "take the following" - "Represent the num of instances" -> "Represents the number of instances"
fwiesel
force-pushed
the
upgrade-controller-gen
branch
from
450cea6 to
80fdf46
Compare
'request an reboot/evacuation' -> 'requests a reboot/an evacuation'; 'Require to issue...' -> clearer imperative phrasing; 'enable the installations...' -> 'enables installation...'. These strings propagate into CRD schema descriptions, so regen follows.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
notandy
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI installs
controller-gen@latestwhich is now v0.21.0. The new version correctly omits the namespace parameter from apply configuration constructors for cluster-scoped resources (Hypervisor, Eviction).Without this regeneration, CI's
generatestep produces a 1-argEviction()/Hypervisor()signature while the committed code has the stale 2-arg version from v0.19.0. This causes build failures on any branch that calls these constructors (e.g.ssa,rework-onboarding).This PR only contains regenerated output — no hand-written code changes.
Summary by CodeRabbit
New Features
Documentation
Chores