Migrate AggregatesController to SSA status updates#342
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Replace PatchHypervisorStatusWithRetry with Status().Apply() for ConditionTypeAggregatesUpdated and the Aggregates slice. The error path includes the current Aggregates in the apply to prevent SSA from pruning previously-set values on a transient OpenStack error. Clearing aggregates to an empty slice uses a targeted merge patch to work around the omitempty limitation in the generated apply configuration type. Seed only ConditionTypeAggregatesUpdated so SSA does not claim ownership over conditions written by other controllers.
181d69b to
7d13627
Compare
|
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Replace
PatchHypervisorStatusWithRetrywithStatus().Apply()forConditionTypeAggregatesUpdatedand theAggregatesslice. The error path includes the currentAggregatesin the apply to prevent SSA from pruning previously-set values on a transient OpenStack error.Clearing aggregates to an empty slice uses a targeted merge patch to work around the
omitemptylimitation in the generated apply configuration type.Seed only
ConditionTypeAggregatesUpdatedso SSA does not claim ownership over conditions written by other controllers.Depends on #335 (
ssa-conditions-helpers).