Skip to content

Migrate ready.Controller to SSA status updates#344

Open
fwiesel wants to merge 1 commit into
ssa-conditions-helpersfrom
ssa-ready
Open

Migrate ready.Controller to SSA status updates#344
fwiesel wants to merge 1 commit into
ssa-conditions-helpersfrom
ssa-ready

Conversation

@fwiesel

@fwiesel fwiesel commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Replace PatchHypervisorStatusWithRetry with Status().Apply() for ConditionTypeReady. Seed only that condition so SSA does not claim ownership over conditions written by other controllers.

Note: this PR does not yet remove internal/utils/status_patch.go — that happens in the final ssa-cleanup PR (#TBD) once every other controller has migrated.

Depends on #335 (ssa-conditions-helpers).

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 81e83133-4e04-4256-a64f-571adb4be82a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ssa-ready

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fwiesel

fwiesel commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Replace PatchHypervisorStatusWithRetry with Status().Apply() for
ConditionTypeReady. Seed only that condition so SSA does not claim
ownership over conditions written by other controllers.
@github-actions

Copy link
Copy Markdown

⚠️ Note: Baseline coverage from ssa-conditions-helpers branch is not available (artifact may be expired). Showing current coverage for changed files only.

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/ready 73.21% (+73.21%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/ready/controller.go 73.21% (+73.21%) 56 (+56) 41 (+41) 15 (+15) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant