Nixos 26.05#31
Open
hertrste wants to merge 24 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (24)
🚧 Files skipped from review as they are similar to previous changes (22)
📝 WalkthroughWalkthroughThis PR updates nixpkgs, adds OpenStack and Django package expressions and wiring, migrates many Python derivations to explicit pyproject builds, renames dependencies, applies package-specific build fixes, and adjusts integration tests and generated text. ChangesNixpkgs upgrade and package build migration
Estimated code review effort: 4 (Complex) | ~60 minutes Test infrastructure and documentation updates
Estimated code review effort: 4 (Complex) | ~60 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
Due to newer packages in nixos 26.05 we need a small patch for the old oslo-log to still work Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de> On-behalf-of: SAP stefan.kober@sap.com
pkr4711
force-pushed
the
nixos-26.05
branch
5 times, most recently
from
e96b715 to
729bf9c
Compare
Contributor
|
@hertrste I have continued with our work. The pipeline is 🟢 I had to add a few more nix packages in older versions than those currently available in nixos-26.05. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (6)
packages/python-cinderclient.nix (1)
67-67: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a comment explaining the test exclusion.
A brief inline comment (e.g.,
# test_load_versioned_actions_with_help is flaky on NixOS 26.05) would help future maintainers understand why this specific test is excluded and when it might be safe to remove the exclusion.💡 Suggested addition
checkPhase = '' - stestr run --exclude-regex test_load_versioned_actions_with_help + # Excluded: test_load_versioned_actions_with_help is flaky on NixOS 26.05 + stestr run --exclude-regex test_load_versioned_actions_with_help🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/python-cinderclient.nix` at line 67, Add a brief inline comment near the stestr invocation in the python-cinderclient.nix test step explaining why test_load_versioned_actions_with_help is excluded; document that it is flaky on NixOS 26.05 (or the specific platform issue) so future maintainers can understand the exclusion and know when it may be safe to remove it.packages/doc8.nix (1)
19-26: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuePotential redundancy:
setuptools-scmin bothbuild-systemandnativeBuildInputs.With
pyproject = trueandbuild-systemspecified, the Nix Python build infrastructure already makessetuptools-scmavailable during the build. Having it also innativeBuildInputs(line 26) may be redundant. If this is intentional for a transition period, consider adding a brief comment; otherwise, thenativeBuildInputsentry can likely be removed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/doc8.nix` around lines 19 - 26, `setuptools-scm` is listed twice for the doc8 derivation, once in `build-system` and again in `nativeBuildInputs`. Update the `doc8` Nix expression to keep the dependency only in `build-system` if that is sufficient under `pyproject = true`, and remove the duplicate `nativeBuildInputs` entry unless you need it temporarily for a migration comment. Use the `build-system` and `nativeBuildInputs` sections in `packages/doc8.nix` to locate the change.packages/enmerkar.nix (1)
2-21: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider using
python3Packages.setuptoolsdirectly inbuild-systemfor consistency.Other files in this PR (e.g.,
automaton.nix,castellan.nix,etcd3gw.nix,suds-community.nix) referencepython3Packages.setuptoolsdirectly inbuild-system, while this file uses the localsetuptoolsbinding from theinheritlist. Both are functionally equivalent, but aligning the style would improve cross-file consistency.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/enmerkar.nix` around lines 2 - 21, The build-system declaration in the enmerkar package uses the locally inherited setuptools binding, which is inconsistent with the style used in the other Nix package definitions. Update the python3Packages.buildPythonPackage expression to reference python3Packages.setuptools directly in build-system, keeping the rest of the package definition unchanged and aligned with the other files.packages/python-openstackclient.nix (1)
35-42: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove redundant dependency listings.
pbrinnativeBuildInputs(line 41) is already declared inbuild-system(line 36) — thenativeBuildInputsblock is entirely redundant. Additionally,stestrappears in bothcheckInputs(line 61) andnativeCheckInputs(line 65). In modern Nixpkgs withpyproject = true,nativeCheckInputsis the preferred attribute;checkInputsis legacy. Consolidating all check dependencies intonativeCheckInputsand droppingnativeBuildInputswould align with current best practices.♻️ Proposed cleanup
build-system = [ python3Packages.pbr python3Packages.setuptools ]; - nativeBuildInputs = [ - pbr - ]; - dependencies = [ cliff cryptography iso8601 openstacksdk osc-lib oslo-i18n pbr python-cinderclient python-keystoneclient requests stevedore ]; - checkInputs = [ - ddt - requests-mock - stestr - ]; - nativeCheckInputs = [ + ddt + requests-mock stestr ];Also applies to: 58-66
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/python-openstackclient.nix` around lines 35 - 42, The package definition has redundant dependency declarations: remove the unnecessary pbr entry from nativeBuildInputs since it is already covered by build-system, and consolidate all test-time dependencies into nativeCheckInputs in the python-openstackclient.nix derivation. Update the relevant dependency blocks around build-system, nativeBuildInputs, checkInputs, and nativeCheckInputs so that stestr is only listed once and checkInputs is no longer used for this pyproject-based build.packages/python-glanceclient.nix (1)
83-96: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove redundant
checkInputsblock.Every entry in
checkInputsis already available during the check phase via other attributes:
ddt,requests-mock,testscenarios→ already innativeCheckInputs(lines 75-81)keystoneauth1,oslo-i18n,oslo-utils,pbr,prettytable,pyopenssl,requests,warlock,wrapt→ already inpropagatedBuildInputs(lines 63-73), which are available during checkThe entire block is dead weight and makes it harder to maintain accurate dependency lists.
♻️ Proposed fix
nativeCheckInputs = [ ddt openstacksdk requests-mock stestr testscenarios ]; - checkInputs = [ - ddt - keystoneauth1 - oslo-i18n - oslo-utils - pbr - prettytable - pyopenssl - requests - requests-mock - testscenarios - warlock - wrapt - ]; - checkPhase = ''🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/python-glanceclient.nix` around lines 83 - 96, Remove the redundant checkInputs block from the python-glanceclient derivation, since the listed packages are already covered by nativeCheckInputs and propagatedBuildInputs. Update the package definition by deleting the checkInputs attribute entirely and keep the dependency lists centralized in the existing nativeCheckInputs and propagatedBuildInputs sections so the derivation stays accurate and easier to maintain.packages/horizon.nix (1)
91-96: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
doCheck = falsedisables all tests for horizon.This may be necessary during the NixOS 26.05 migration, but tests should be re-enabled once dependencies stabilize. Consider adding a TODO or tracking issue to re-enable checks in a follow-up.
The
pyproject = true,build-system = [pbr, setuptools], andpythonRelaxDeps = [ "django" ]configuration looks correct for the OpenStack/Django packaging migration.Also applies to: 197-197
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/horizon.nix` around lines 91 - 96, The current horizon packaging disables all checks with doCheck = false, so update the horizon derivation to leave a clear TODO or tracking reference near the existing doCheck setting indicating that tests must be re-enabled once dependencies stabilize. Keep the pyproject, build-system, and pythonRelaxDeps configuration as-is, and make the reminder easy to find alongside the horizon package definition so it can be revisited during the NixOS 26.05 migration follow-up.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/django-compressor.nix`:
- Around line 17-28: `django-compressor` is declaring `rcssmin` and `rjsmin` in
`nativeBuildInputs`, but they are imported at runtime and need to be available
to downstream consumers. Update the `django-compressor` Nix expression to move
both dependencies into `propagatedBuildInputs` while keeping build-time-only
tools in `nativeBuildInputs`; use the `nativeBuildInputs` and
`propagatedBuildInputs` sections in this package definition to make the runtime
closure complete.
In `@packages/django.nix`:
- Around line 19-24: Move Django’s runtime dependencies out of the build-only
dependency list: in the django package definition, keep the build-system tools
in nativeBuildInputs and place asgiref and sqlparse in propagatedBuildInputs so
downstream packages receive them automatically. Use the existing package
expression around the build inputs in the Django derivation to separate
build-time tools from runtime dependencies, matching the pattern used in
django-pyscss.nix.
In `@packages/horizon.nix`:
- Around line 104-108: Horizon’s runtime closure is missing rcssmin for
django-compressor, since it is only declared as a nativeBuildInput in
packages/django-compressor.nix. Update the packaging so rcssmin is included in
propagatedBuildInputs for the django-compressor derivation, or add a direct
Horizon dependency if that is the only consumer, and verify the relevant package
definitions still reference django-compressor consistently.
In `@packages/nova.nix`:
- Around line 120-132: The replacement in postPatch for nova/virt/disk/api.py
changes the crypt shim but does not preserve crypt.crypt()’s None-on-error
behavior. Update the crypt class’ crypt() method to check the ctypes call result
from _libcrypt.crypt before decoding, and return None when the C function
returns NULL; only decode when a real pointer is present.
In `@packages/python-designateclient.nix`:
- Around line 31-32: The python-designateclient package is missing the explicit
PBR build-system dependencies even though pyproject is enabled. Update the
package definition to add the required build-system entries alongside pyproject
= true, using the same pattern as the other OpenStack package definitions in
this PR, so the build can resolve pbr and setuptools correctly.
---
Nitpick comments:
In `@packages/doc8.nix`:
- Around line 19-26: `setuptools-scm` is listed twice for the doc8 derivation,
once in `build-system` and again in `nativeBuildInputs`. Update the `doc8` Nix
expression to keep the dependency only in `build-system` if that is sufficient
under `pyproject = true`, and remove the duplicate `nativeBuildInputs` entry
unless you need it temporarily for a migration comment. Use the `build-system`
and `nativeBuildInputs` sections in `packages/doc8.nix` to locate the change.
In `@packages/enmerkar.nix`:
- Around line 2-21: The build-system declaration in the enmerkar package uses
the locally inherited setuptools binding, which is inconsistent with the style
used in the other Nix package definitions. Update the
python3Packages.buildPythonPackage expression to reference
python3Packages.setuptools directly in build-system, keeping the rest of the
package definition unchanged and aligned with the other files.
In `@packages/horizon.nix`:
- Around line 91-96: The current horizon packaging disables all checks with
doCheck = false, so update the horizon derivation to leave a clear TODO or
tracking reference near the existing doCheck setting indicating that tests must
be re-enabled once dependencies stabilize. Keep the pyproject, build-system, and
pythonRelaxDeps configuration as-is, and make the reminder easy to find
alongside the horizon package definition so it can be revisited during the NixOS
26.05 migration follow-up.
In `@packages/python-cinderclient.nix`:
- Line 67: Add a brief inline comment near the stestr invocation in the
python-cinderclient.nix test step explaining why
test_load_versioned_actions_with_help is excluded; document that it is flaky on
NixOS 26.05 (or the specific platform issue) so future maintainers can
understand the exclusion and know when it may be safe to remove it.
In `@packages/python-glanceclient.nix`:
- Around line 83-96: Remove the redundant checkInputs block from the
python-glanceclient derivation, since the listed packages are already covered by
nativeCheckInputs and propagatedBuildInputs. Update the package definition by
deleting the checkInputs attribute entirely and keep the dependency lists
centralized in the existing nativeCheckInputs and propagatedBuildInputs sections
so the derivation stays accurate and easier to maintain.
In `@packages/python-openstackclient.nix`:
- Around line 35-42: The package definition has redundant dependency
declarations: remove the unnecessary pbr entry from nativeBuildInputs since it
is already covered by build-system, and consolidate all test-time dependencies
into nativeCheckInputs in the python-openstackclient.nix derivation. Update the
relevant dependency blocks around build-system, nativeBuildInputs, checkInputs,
and nativeCheckInputs so that stestr is only listed once and checkInputs is no
longer used for this pyproject-based build.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 73f7b7dc-f764-4977-a33c-f9a23a23b90b
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (117)
checks/.typos.tomlflake.nixlib/rootwrap-conf.nixmodules/controller/horizon.nixmodules/controller/neutron.nixmodules/default.nixmodules/testing/README.mdmodules/testing/default.nixpackages/automaton.nixpackages/castellan.nixpackages/cinder.nixpackages/cursive.nixpackages/default.nixpackages/django-appconf.nixpackages/django-compressor.nixpackages/django-debreach.nixpackages/django-discover-runner.nixpackages/django-pyscss.nixpackages/django.nixpackages/doc8.nixpackages/enmerkar.nixpackages/etcd3gw.nixpackages/futurist.nixpackages/gabbi.nixpackages/glance-store.nixpackages/glance.nixpackages/horizon.nixpackages/jsonpath-rw-ext.nixpackages/keystone.nixpackages/keystoneauth1.nixpackages/keystonemiddleware.nixpackages/microversion-parse.nixpackages/neutron-lib.nixpackages/neutron.nixpackages/nova.nixpackages/openstack-placement.nixpackages/os-brick.nixpackages/os-client-config.nixpackages/os-ken.nixpackages/os-resource-classes.nixpackages/os-traits.nixpackages/os-vif.nixpackages/os-win.nixpackages/osc-placement.nixpackages/oslo-cache.nixpackages/oslo-concurrency.nixpackages/oslo-config.nixpackages/oslo-context.nixpackages/oslo-db.nixpackages/oslo-i18n.nixpackages/oslo-limit.nixpackages/oslo-log.nixpackages/oslo-messaging.nixpackages/oslo-metrics.nixpackages/oslo-middleware.nixpackages/oslo-policy.nixpackages/oslo-privsep.nixpackages/oslo-reports.nixpackages/oslo-rootwrap.nixpackages/oslo-serialization.nixpackages/oslo-service.nixpackages/oslo-upgradecheck.nixpackages/oslo-utils.nixpackages/oslo-versionedobjects.nixpackages/oslo-vmware.nixpackages/oslotest.nixpackages/osprofiler.nixpackages/ovs.nixpackages/ovsdbapp.nixpackages/patches/oslo-log-pipe-mutex-context-manager.patchpackages/pre-commit.nixpackages/pycadf.nixpackages/python-barbicanclient.nixpackages/python-binary-memcached.nixpackages/python-cinderclient.nixpackages/python-designateclient.nixpackages/python-glanceclient.nixpackages/python-keystoneclient.nixpackages/python-neutronclient.nixpackages/python-novaclient.nixpackages/python-openstackclient.nixpackages/python-swiftclient.nixpackages/rcssmin.nixpackages/reno.nixpackages/rjsmin.nixpackages/sphinxcontrib-svg2pdfconverter.nixpackages/sqlalchemy.nixpackages/suds-community.nixpackages/taskflow.nixpackages/tooz.nixpackages/xstatic-angular-bootstrap.nixpackages/xstatic-angular-fileupload.nixpackages/xstatic-angular-gettext.nixpackages/xstatic-angular-lrdragndrop.nixpackages/xstatic-angular-schema-form.nixpackages/xstatic-angular.nixpackages/xstatic-bootstrap-datepicker.nixpackages/xstatic-bootstrap-scss.nixpackages/xstatic-bootswatch.nixpackages/xstatic-d3.nixpackages/xstatic-font-awesome.nixpackages/xstatic-hogan.nixpackages/xstatic-jasmine.nixpackages/xstatic-jquery-migrate.nixpackages/xstatic-jquery-quicksearch.nixpackages/xstatic-jquery-tablesorter.nixpackages/xstatic-jsencrypt.nixpackages/xstatic-mdi.nixpackages/xstatic-objectpath.nixpackages/xstatic-rickshaw.nixpackages/xstatic-roboto-fontface.nixpackages/xstatic-smart-table.nixpackages/xstatic-spin.nixpackages/xstatic-term-js.nixpackages/xstatic-tv4.nixtests/openstack-default-setup.nixtests/openstack-live-migration.nix
Comment on lines
+120
to
+132
| postPatch = '' | ||
| substituteInPlace nova/virt/disk/api.py \ | ||
| --replace-fail " import crypt" ' import ctypes | ||
| _libcrypt = ctypes.CDLL("${lib.getLib libxcrypt-legacy}/lib/libcrypt.so.1") | ||
| _libcrypt.crypt.argtypes = [ctypes.c_char_p, ctypes.c_char_p] | ||
| _libcrypt.crypt.restype = ctypes.c_char_p | ||
|
|
||
| class crypt: | ||
| @staticmethod | ||
| def crypt(word, salt): | ||
| result = _libcrypt.crypt(word.encode("utf-8"), salt.encode("utf-8")) | ||
| return result.decode("utf-8")' | ||
| ''; |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
sed -n '100,150p' packages/nova.nixRepository: cobaltcore-dev/openstack-nix
Length of output: 1360
🏁 Script executed:
grep -RIn "class crypt" -n . || trueRepository: cobaltcore-dev/openstack-nix
Length of output: 207
🏁 Script executed:
python3 - <<'PY'
import ctypes
lib = ctypes.CDLL(None)
# probe semantics of c_char_p returning NULL
lib.malloc.restype = ctypes.c_void_p
PYRepository: cobaltcore-dev/openstack-nix
Length of output: 166
🏁 Script executed:
rg -n "class crypt|_libcrypt\.crypt|import crypt" -S .Repository: cobaltcore-dev/openstack-nix
Length of output: 555
🏁 Script executed:
python3 - <<'PY'
import ctypes
CALLBACK = ctypes.CFUNCTYPE(ctypes.c_char_p)
`@CALLBACK`
def returns_null():
return None
result = returns_null()
print("result:", result, type(result))
try:
print(result.decode("utf-8"))
except Exception as e:
print(type(e).__name__, e)
PYRepository: cobaltcore-dev/openstack-nix
Length of output: 257
Handle NULL from C crypt(). ctypes.c_char_p maps a NULL return to None, so result.decode("utf-8") raises AttributeError instead of preserving crypt.crypt()’s None-on-error behavior. Add a null guard before decoding.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/nova.nix` around lines 120 - 132, The replacement in postPatch for
nova/virt/disk/api.py changes the crypt shim but does not preserve
crypt.crypt()’s None-on-error behavior. Update the crypt class’ crypt() method
to check the ctypes call result from _libcrypt.crypt before decoding, and return
None when the C function returns NULL; only decode when a real pointer is
present.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/django-compressor.nix`:
- Around line 21-26: Move the runtime Python dependencies from nativeBuildInputs
to propagatedBuildInputs in the django-compressor derivation so downstream users
receive them automatically. Specifically, keep build-only tools like pip and
setuptools in nativeBuildInputs, but add django and django-appconf to
propagatedBuildInputs in the django-compressor package definition. This ensures
the imports used by django-compressor at runtime are available to dependents
without requiring them to declare those packages separately.
In `@packages/django-discover-runner.nix`:
- Around line 18-21: Move django back from nativeBuildInputs to
propagatedBuildInputs in the django-discover-runner derivation, since it is
imported and extended at runtime by the plugin. Keep pip and setuptools in
nativeBuildInputs, and ensure the package expression for django-discover-runner
preserves django in the transitive runtime closure so downstream consumers
receive it automatically.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 806bd522-5ef8-4364-a6f2-a6183d6b946b
📒 Files selected for processing (14)
flake.nixpackages/default.nixpackages/django-appconf.nixpackages/django-compressor.nixpackages/django-debreach.nixpackages/django-discover-runner.nixpackages/django-pyscss.nixpackages/django.nixpackages/enmerkar.nixpackages/horizon.nixpackages/python-designateclient.nixpackages/python-glanceclient.nixpackages/rcssmin.nixpackages/rjsmin.nix
✅ Files skipped from review due to trivial changes (2)
- packages/django-appconf.nix
- packages/rjsmin.nix
🚧 Files skipped from review as they are similar to previous changes (8)
- packages/rcssmin.nix
- packages/django-debreach.nix
- packages/python-glanceclient.nix
- packages/django-pyscss.nix
- packages/python-designateclient.nix
- packages/enmerkar.nix
- packages/horizon.nix
- packages/default.nix
Replace python-ldap package with renamed package ldap. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Target versions are from our OpenStack release: https://releases.openstack.org/dalmatian/ Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Use of the newly created packages. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Use of the newly created packages in our tests. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
In github ci the test vm need >= 45 to boot. It's longer than in a local test. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Target versions are from our OpenStack release: https://releases.openstack.org/dalmatian/ This package is a dependency of horizon dashbaord. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Target versions are from our OpenStack release: https://releases.openstack.org/dalmatian/ This package is a dependency of horizon dashbaord. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Target versions are from our OpenStack release: https://releases.openstack.org/dalmatian/ This package is a dependency of horizon dashbaord. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Target versions are from our OpenStack release: https://releases.openstack.org/dalmatian/ This package is a dependency of horizon dashbaord. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Target versions are from our OpenStack release: https://releases.openstack.org/dalmatian/ This package is a dependency of horizon dashbaord. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Create an older version of this package. Nixos-2605 only contains newer packages that are not compatible with this OpenStack version. Target versions are from our OpenStack release: https://releases.openstack.org/dalmatian/ Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Use newly created packages in horizon and fix further python dependencies of horizon. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Fix build inputs of this package. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
Package django is a runtime dependency of django-discover-runner and should be included in the built package. Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de> On-behalf-of: SAP paul.kroeher@sap.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of changes in the python package builds were required. Additionally, some patches to certain libs that had breaking changes.
Summary by CodeRabbit